Re: [patch 00/53] x86/topology: The final installment

Zhang, Rui
2023-08-10T03:28:16Z

Hi, Thomas,

> > CPU topo: Max. logical packages:   2
> > CPU topo: Max. logical dies:       2
> > CPU topo: Max. dies per package:   1
> > CPU topo: Max. threads per core:   2
> > CPU topo: Num. cores per package:    10
> > CPU topo: Num. threads per package:  20
> > CPU topo: Allowing 40 present CPUs plus 0 hotplug CPUs
> > CPU topo: Thread    :    40
> > CPU topo: Core      :    20
> > CPU topo: Module    :     2
> > CPU topo: Tile      :     2
> > CPU topo: Die       :     2
> > CPU topo: Package   :     2
> >
> > domain: Thread     shift: 1 dom_size:     2 max_threads:     2
> > domain: Core       shift: 5 dom_size:    16 max_threads:    32
> > domain: Module     shift: 5 dom_size:     1 max_threads:    32
> > domain: Tile       shift: 5 dom_size:     1 max_threads:    32
> > domain: Die        shift: 5 dom_size:     1 max_threads:    32
> > domain: Package    shift: 5 dom_size:     1 max_threads:    32
> >
> > /sys/kernel/debug/x86/topo/cpus/39
> > online:              1
> > initial_apicid:      39
> > apicid:              39
> > pkg_id:              1
> > die_id:              1
> > cu_id:               255
> > core_id:             12
> > logical_pkg_id:      1
> > logical_die_id:      1
> > llc_id:              32
> > l2c_id:              56
> > amd_node_id:         0
> > amd_nodes_per_pkg:   0
> > num_threads:         20
> > num_cores:           10
> > max_dies_per_pkg:    1
> > max_threads_per_core:2
>
> That makes much more sense now.
>
> Zhang, can you please follow up on:
>
>
> https://lore.kernel.org/all/613df280116378115585d0c483f7e186cffaeb58.camel@intel.com/
>
> or otherwise I just polish up PeterZ's variant of it tomorrow.
>
Sorry for the late response. I was in the reviewing of the previous
patch series and missed this one.

IMO, PeterZ' patch already follows the suggestion at
https://lore.kernel.org/all/87pm4bp54z.ffs@tglx/
And https://lore.kernel.org/all/87jzukqjvf.ffs@tglx/ is not needed
because there are no duplicate APIC IDs from LAPIC and x2APIC anymore
with the above patch.

So I think we can go with PeterZ' patch.

thanks,
rui