From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22588C4167B for ; Tue, 5 Dec 2023 17:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345206AbjLERCy (ORCPT ); Tue, 5 Dec 2023 12:02:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231861AbjLERCw (ORCPT ); Tue, 5 Dec 2023 12:02:52 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F5561B6; Tue, 5 Dec 2023 09:02:57 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1701795775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tKj/G59HmDBT/RcKJNhjfacQG0y6lbGXbN5/YyhoGFQ=; b=gBs2xU/8H+BYBNLyCeYcxWGK2DZm4IabnOmpFdODKMdgkBPuxusYpkJuD8d5nh/R3KLnbv x5HOmiKZACda/7MqInA95GLLoSjFc6ZbPAHItZhCLbXpNfG3vEP8PEeAv0Dyhl0ZN/i5p4 D36nAXuQqr6TgdWMOQNCHWsCvy69bXXMfTa4MjCEVvmGElsCn7OmsxHPtkilqKWMZmCn8s WgGntur+yfvv0BQdbGoMsjQqWyqyXeiiJ0BlpPUYpuPujZWY1I4IA7ixlnPTzRjMbnL3E9 ql34epQy/+k5Z+geYL3XccPv8qe8KR/gW2//csS7+XQIbeTKK4sr4lXiM6fONw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1701795775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tKj/G59HmDBT/RcKJNhjfacQG0y6lbGXbN5/YyhoGFQ=; b=ycX4aADBX6fBhOk+amfiCNFdHlR2j22kpskGtkhiZY8tFpmyEFOH2YLz4yXuMW8J2h7zyH rHbpCWNVp2OWgABA== To: Stefano Stabellini , "Chen, Jiqian" Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Roger Pau =?utf-8?Q?Monn=C3=A9?= , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Stabellini, Stefano" , "Deucher, Alexander" , "Koenig, Christian" , "Hildebrand, Stewart" , "Ragiadakou, Xenia" , "Huang, Honglei1" , "Zhang, Julia" , "Huang, Ray" Subject: Re: [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function In-Reply-To: References: <20231124103123.3263471-1-Jiqian.Chen@amd.com> <20231124103123.3263471-2-Jiqian.Chen@amd.com> <87edg2xuu9.ffs@tglx> Date: Tue, 05 Dec 2023 18:02:54 +0100 Message-ID: <87fs0gwpj5.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 04 2023 at 13:31, Stefano Stabellini wrote: > On Mon, 3 Dec 2023, Chen, Jiqian wrote: >> >> vpci device state when device is reset on dom0 side. >> >> >> >> And call that function in pcistub_init_device. Because when >> >> we use "pci-assignable-add" to assign a passthrough device in >> >> Xen, it will reset passthrough device and the vpci state will >> >> out of date, and then device will fail to restore bar state. >> >> >> >> Signed-off-by: Jiqian Chen >> >> Signed-off-by: Huang Rui >> > >> > This Signed-off-by chain is incorrect. >> > >> > Documentation/process/submitting-patches.rst has a full chapter about >> > S-O-B and the correct usage. >> I am the author of this series of patches, and Huang Rui transported the v1 to upstream. And now I transport v2. I am not aware that the SOB chain is incorrect. >> Do you have any suggestions? > > I think he means that your Signed-off-by should be the second one of the > two as you are the one submitting the patch to the LKML No. Mailfrom: Jiqian Chen Changelog-text Signed-off-by: Huang Rui Signed-off-by: Jiqian Chen is equally wrong because that would end up with Chen as author and Huang as first S-O-B which is required to be the author's S-O-B To make the above correct this would require: Mailfrom: Jiqian Chen From: Huang Rui Changelog-text Signed-off-by: Huang Rui Signed-off-by: Jiqian Chen which tells that Huang is the author and Chen is the 'transporter', which unfortunately does not reflect reality. Or: Mailfrom: Jiqian Chen Changelog-text Co-developed-by: Huang Rui Signed-off-by: Huang Rui Signed-off-by: Jiqian Chen which tells that Checn is the author and Huang co-developed the patch, which might be true or not. V1 which was sent by Huang has the ordering is correct: Mailfrom: Huang Rui From: Jiqian Chen Changelog-text Signed-off-by: Jiqian Chen Signed-off-by: Huang Rui i.e. Chen authored and Huang transported Now this V2 has not really much to do with V1 and is a new implementation to solve the problem, which was authored by Chen, so Huang is not involved at all if I understand correctly. So what does his S-O-B mean here? Nothing... It's very well documented how the whole S-O-B business works and it's not really rocket science to get it straight. It has a meaning and is not just for decoration purposes. Thanks, tglx