From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 402EBC61D85 for ; Tue, 21 Nov 2023 14:26:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234256AbjKUO0g (ORCPT ); Tue, 21 Nov 2023 09:26:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233608AbjKUO01 (ORCPT ); Tue, 21 Nov 2023 09:26:27 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9A2B1A3; Tue, 21 Nov 2023 06:26:23 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0D1AF1F8BF; Tue, 21 Nov 2023 14:26:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1700576782; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rEuossM4JQY9JZ11rmGjFmuYHEzbTy8cDDjv1mfs8ps=; b=Ow3glYItRxjzgdERrVcWs2t1URa3x43jhS++pNSWgBQj8Qki8lxkgIRw1tg43fqiz0hFCM WMDmBBqE9WoqMddg0GOcY92geB10jOzP32k9+NW2qgvT3cY0T4qT6IjJEEyVLPhY7bGQQa WtWGAPDisyzCpfNpPj0ChJHE7uEruMc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1700576782; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rEuossM4JQY9JZ11rmGjFmuYHEzbTy8cDDjv1mfs8ps=; b=D1An8EjuY83yk7KfZIv+/C3MztaF9sHChe2a+wLweUqwV5R2lcYDWQ7mlL4vpzlvy2z/mO LwsvEZv0i1szmNBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BABCC138E3; Tue, 21 Nov 2023 14:26:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9J+4LA2+XGUXUgAAMHmgww (envelope-from ); Tue, 21 Nov 2023 14:26:21 +0000 Date: Tue, 21 Nov 2023 15:26:21 +0100 Message-ID: <87fs0zmbci.wl-tiwai@suse.de> From: Takashi Iwai To: Hans de Goede Cc: Takashi Iwai , Thorsten Leemhuis , Jean-Jacques Hiblot , Bagas Sanjaya , Linux Kernel Mailing List , Linux Regressions , Linux LEDs , Tim Crawford , Jeremy Soller , System76 Product Development , Lee Jones , Pavel Machek , Johannes =?ISO-8859-1?Q?Pe?= =?ISO-8859-1?Q?n=DFel?= Subject: Re: Fwd: sysfs: cannot create duplicate filename .../system76_acpi::kbd_backlight/color In-Reply-To: <37f6aa8e-8cab-4194-8493-8e39819ed608@redhat.com> References: <87sf50pm34.wl-tiwai@suse.de> <87edgjo2kr.wl-tiwai@suse.de> <874jhfo0oc.wl-tiwai@suse.de> <37f6aa8e-8cab-4194-8493-8e39819ed608@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-5.80 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_TWELVE(0.00)[14]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[suse.de,leemhuis.info,traphandler.com,gmail.com,vger.kernel.org,lists.linux.dev,system76.com,kernel.org,ucw.cz]; RCVD_COUNT_TWO(0.00)[2]; SUSPICIOUS_RECIPS(1.50)[] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Nov 2023 13:23:20 +0100, Hans de Goede wrote: > > Hi, > > On 11/21/23 11:33, Takashi Iwai wrote: > > On Tue, 21 Nov 2023 11:21:53 +0100, > > Hans de Goede wrote: > >> > >> Hi, > >> > >> On 11/21/23 10:52, Takashi Iwai wrote: > >>> On Tue, 21 Nov 2023 10:19:03 +0100, > >>> Thorsten Leemhuis wrote: > >>>> > >>>> Takashi, Jean-Jacques Hiblot, Lee, > >>>> > >>>> On 20.11.23 14:53, Takashi Iwai wrote: > >>>>> On Mon, 06 Nov 2023 14:19:08 +0100, > >>>>> Bagas Sanjaya wrote: > >>>>>> On Sat, Nov 04, 2023 at 01:01:56PM +0100, Jean-Jacques Hiblot wrote: > >>>>>>> On 29/10/2023 02:48, Bagas Sanjaya wrote: > >>>>>>>> On Thu, Oct 26, 2023 at 02:55:06PM +0700, Bagas Sanjaya wrote: > >>>>>>>>> The culprit seems to be commit c7d80059b086c4986cd994a1973ec7a5d75f8eea, which introduces a new 'color' attribute for led sysfs class devices. The problem is that the system76-acpi platform driver tries to create the exact same sysfs attribute itself for the system76_acpi::kbd_backlight device, leading to the conflict. For testing purposes, I've just rebuilt the kernel with the system76-apci color attribute renamed to kb_color, and that fixes the issue. > >>>>>>>> > >>>>>>>> Jean-Jacques Hiblot, would you like to take a look on this regression, > >>>>>>>> since you authored the culprit? > >>>>> > >>>>>>> The offending commit stores the color in struct led_classdev and exposes it > >>>>>>> via sysfs. It was part of a series that create a RGB leds from multiple > >>>>>>> single-color LEDs. for this series, we need the color information but we > >>>>>>> don't really need to expose it it via sysfs. In order to fix the issue, we > >>>>>>> can remove the 'color' attribute from the sysfs. > >>>>>> > >>>>>> OK, see you in the patch! > >>>>> > >>>>> Is there a patch available? > >>>> > >>>> Not that I know of. Could not find anything on lore either. > >>>> > >>>>> This bug hits for a few Logitech keyboard models, too, and it makes > >>>>> 6.6 kernel unsable for them, as hid-lg-g15 driver probe fails due to > >>>>> this bug: > >>>>> https://bugzilla.kernel.org/show_bug.cgi?id=218155 > >>>>> > >>>>> We need a quick fix for 6.6.x. > >>>> > >>>> Given that Jean-Jacques Hiblot (the author of the culprit) and Lee (who > >>>> committed it and sent it to Linus) know about this for a while already > >>>> without doing anything about it, I wonder if someone should just send a > >>>> revert to Linus (unless of course that is likely to introduce a > >>>> regression on its own). > >>>> > >>>> Takashi, could you maybe do this, unless a fix shows up real soon? > >>> > >>> I can, but we need to decide which way to go. > >>> There are several options: > >>> > >>> 1. Revert the commit c7d80059b086; > >>> this drops led class color sysfs entries. Also the store of > >>> led_cdev->color from fwnode is dropped, too. > >>> > >>> 2. Drop only led class color sysfs entries; > >>> a partial revert of c7d80059b086 above > >> > >> AFAIK further up in the thread (or a related thread) there > >> already was consensus to do this. Someone just needs to > >> write the patch. > > > > Well, is there any user of this new led_classdev.color field? > > The value read from fwnode is stored there, but as far as I see, there > > seems no real user, so far. If it's still unused, we can do the whole > > revert -- which is cleaner. > > I honestly don't know. I've mostly just been reading along. I think > there may be some future in kernel use planned (not sure at all though). > > If there are no current in kernel users then I agree we should just > go with a full revert now to fix the regression. If some later > in kernel users do come along then they can always re-introduce > the change minus the sysfs attr addition. Sounds reasonable. OK, let me pitch the revert patch. thanks, Takashi