From: Marc Zyngier <maz@kernel.org>
To: Paran Lee <p4ranlee@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, shjy180909@gmail.com,
austindh.kim@gmail.com
Subject: Re: [PATCH] irqdesc: Fail check on early_irq_init allocation.
Date: Sun, 12 Nov 2023 14:00:42 +0000 [thread overview]
Message-ID: <87fs1bxe9h.wl-maz@kernel.org> (raw)
In-Reply-To: <20231111170035.10386-1-p4ranlee@gmail.com>
On Sat, 11 Nov 2023 17:00:36 +0000,
Paran Lee <p4ranlee@gmail.com> wrote:
>
> When doing start_kernel(),
> On early_irq_init(), alloc_desc() or alloc_percpu()
> may be fails. So, Explicit fail check needed on dynamic allocation.
A failing allocation already results in a massive splat describing how
the allocation failed. Further use of the NULL pointer will also
result in a terminal oops, particularly if this happens this early in
the boot sequence.
So what do these BUG_ON() calls buy us?
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-11-12 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 17:00 [PATCH] irqdesc: Fail check on early_irq_init allocation Paran Lee
2023-11-12 14:00 ` Marc Zyngier [this message]
2023-11-12 14:19 ` Paran Lee
2023-11-12 15:08 ` Marc Zyngier
2023-11-12 15:21 ` Paran Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs1bxe9h.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=austindh.kim@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p4ranlee@gmail.com \
--cc=shjy180909@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox