* [PATCH] ALSA: pci: Missing a blank line after declarations
@ 2023-10-13 1:59 Edson Juliano Drosdeck
2023-10-17 7:45 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Edson Juliano Drosdeck @ 2023-10-13 1:59 UTC (permalink / raw)
To: tiwai; +Cc: perex, alsa-devel, linux-kernel, edson.drosdeck
Warning found by checkpatch.pl script. Adding blank line after declarations.
Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
---
sound/pci/lola/lola_proc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/lola/lola_proc.c b/sound/pci/lola/lola_proc.c
index a166672e22cb..1ee5997da3c9 100644
--- a/sound/pci/lola/lola_proc.c
+++ b/sound/pci/lola/lola_proc.c
@@ -137,6 +137,7 @@ static void lola_proc_codec_rw_write(struct snd_info_entry *entry,
struct lola *chip = entry->private_data;
char line[64];
unsigned int id, verb, data, extdata;
+
while (!snd_info_get_line(buffer, line, sizeof(line))) {
if (sscanf(line, "%u %u %u %u", &id, &verb, &data, &extdata) != 4)
continue;
@@ -150,6 +151,7 @@ static void lola_proc_codec_rw_read(struct snd_info_entry *entry,
struct snd_info_buffer *buffer)
{
struct lola *chip = entry->private_data;
+
snd_iprintf(buffer, "0x%x 0x%x\n", chip->debug_res, chip->debug_res_ex);
}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: pci: Missing a blank line after declarations
2023-10-13 1:59 [PATCH] ALSA: pci: Missing a blank line after declarations Edson Juliano Drosdeck
@ 2023-10-17 7:45 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2023-10-17 7:45 UTC (permalink / raw)
To: Edson Juliano Drosdeck; +Cc: tiwai, perex, alsa-devel, linux-kernel
On Fri, 13 Oct 2023 03:59:51 +0200,
Edson Juliano Drosdeck wrote:
>
> Warning found by checkpatch.pl script. Adding blank line after declarations.
>
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
Thanks for the patch. But in general we take such a white-space
cleanup patch only when it's associated with another real code
changes.
Takashi
> ---
> sound/pci/lola/lola_proc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/lola/lola_proc.c b/sound/pci/lola/lola_proc.c
> index a166672e22cb..1ee5997da3c9 100644
> --- a/sound/pci/lola/lola_proc.c
> +++ b/sound/pci/lola/lola_proc.c
> @@ -137,6 +137,7 @@ static void lola_proc_codec_rw_write(struct snd_info_entry *entry,
> struct lola *chip = entry->private_data;
> char line[64];
> unsigned int id, verb, data, extdata;
> +
> while (!snd_info_get_line(buffer, line, sizeof(line))) {
> if (sscanf(line, "%u %u %u %u", &id, &verb, &data, &extdata) != 4)
> continue;
> @@ -150,6 +151,7 @@ static void lola_proc_codec_rw_read(struct snd_info_entry *entry,
> struct snd_info_buffer *buffer)
> {
> struct lola *chip = entry->private_data;
> +
> snd_iprintf(buffer, "0x%x 0x%x\n", chip->debug_res, chip->debug_res_ex);
> }
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-17 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-13 1:59 [PATCH] ALSA: pci: Missing a blank line after declarations Edson Juliano Drosdeck
2023-10-17 7:45 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox