From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD592CA0FFC for ; Sat, 2 Sep 2023 01:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351478AbjIBBhl (ORCPT ); Fri, 1 Sep 2023 21:37:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbjIBBhj (ORCPT ); Fri, 1 Sep 2023 21:37:39 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CDF8E54; Fri, 1 Sep 2023 18:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1693618650; bh=jmoXZU5xgGIhtHU0V+fopcmXqY/zvLC3ThLQUQfiwJA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ir9Ia+KMa8kP3kdjlB5RMtlq7/v/ajVVR1JjU3X+NDfK2jZtkWp71i2BMrrmrHuTC AddeqMlhnxIfrzRwERIHysj3MX3YJGMlfMNcR57BGQXWeQYzUj3uF1XAhH89IkG6dm I6W9lGIMowGFf+2IxcKKUFCEd6s+R+Yk4UQqLEfc4O/sitzlFK3BL/f1gdWF36+8Ui rzUHl/92BtSgVZ9kFuIMFUoWS5tyMbLRLiY/oQo+vhxhMp79ubNgi6FU3nMCXk6ubl 5Y7eQUUwhFvCrKh/SaFIHHeJ31a15epIyw+hxi+2pFBgByIlG8S40jCeU05uaGsl+H fDSRcsD8tyoIg== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4RcyFJ6359z4wxR; Sat, 2 Sep 2023 11:37:24 +1000 (AEST) From: Michael Ellerman To: Kees Cook , Masahiro Yamada Cc: Kees Cook , Nicolas Schier , Christophe Leroy , Randy Dunlap , linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v3] kbuild: Show marked Kconfig fragments in "help" In-Reply-To: <20230831191335.give.534-kees@kernel.org> References: <20230831191335.give.534-kees@kernel.org> Date: Sat, 02 Sep 2023 11:37:22 +1000 Message-ID: <87fs3xicdp.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees Cook writes: > Currently the Kconfig fragments in kernel/configs and arch/*/configs > that aren't used internally aren't discoverable through "make help", > which consists of hard-coded lists of config fragments. Instead, list > all the fragment targets that have a "# Help: " comment prefix so the > targets can be generated dynamically. > > Add logic to the Makefile to search for and display the fragment and > comment. Add comments to fragments that are intended to be direct targets. > > Cc: Nicolas Schier > Cc: Michael Ellerman > Cc: Christophe Leroy > Cc: Randy Dunlap > Cc: linux-kernel@vger.kernel.org > Cc: x86@kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: linux-kbuild@vger.kernel.org > Cc: linux-hardening@vger.kernel.org > Signed-off-by: Kees Cook > Co-developed-by: Masahiro Yamada > --- > v3: > - Use Makefile logic from Masahiro Yamada > - Use "# Help: " prefix, but only on desired fragment targets > v2: https://lore.kernel.org/all/20230825194329.gonna.911-kees@kernel.org > v1: https://lore.kernel.org/all/20230824223606.never.762-kees@kernel.org > --- > Makefile | 1 - > arch/arm/configs/dram_0x00000000.config | 1 + > arch/arm/configs/dram_0xc0000000.config | 1 + > arch/arm/configs/dram_0xd0000000.config | 1 + > arch/arm/configs/lpae.config | 1 + > arch/arm64/configs/virt.config | 1 + > arch/powerpc/configs/disable-werror.config | 1 + > arch/powerpc/configs/security.config | 4 +++- Acked-by: Michael Ellerman (powerpc) cheers