public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: <vkoul@kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <michal.simek@xilinx.com>,
	<m.tretter@pengutronix.de>, <harini.katakam@amd.com>,
	<dmaengine@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <git@amd.com>
Subject: Re: [PATCH] dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property
Date: Thu, 03 Nov 2022 08:02:00 +0100	[thread overview]
Message-ID: <87fsf0r05z.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1667448757-7001-1-git-send-email-radhey.shyam.pandey@amd.com> (Radhey Shyam Pandey's message of "Thu, 3 Nov 2022 09:42:37 +0530")

>>>>> "Radhey" == Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> writes:

 > xlnx,bus-width is a required property. In yaml conversion somehow
 > it got missed out. Bring it back and mention it in required list.
 > Also add Harini and myself to the maintainer list.

 > Fixes: 5a04982df8da ("dt-bindings: dmaengine: zynqmp_dma: convert to yaml")
 > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
 > ---
 >  .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml    | 3 +++
 >  1 file changed, 3 insertions(+)

 > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
 > index c0a1408b12ec..a10019d3a650 100644
 > --- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
 > +++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
 > @@ -13,6 +13,8 @@ description: |
 
 >  maintainers:
 >    - Michael Tretter <m.tretter@pengutronix.de>
 > +  - Harini Katakam <harini.katakam@amd.com>
 > +  - Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>

That should ideally be in a separate patch.


 >  allOf:
 >    - $ref: "../dma-controller.yaml#"
 > @@ -65,6 +67,7 @@ required:
 >    - interrupts
 >    - clocks
 >    - clock-names
 > +  - xlnx,bus-width

Reviewed-by: Peter Korsgaard <peter@korsgaard.com>

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2022-11-03  7:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03  4:12 [PATCH] dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property Radhey Shyam Pandey
2022-11-03  7:02 ` Peter Korsgaard [this message]
2022-11-03 13:20 ` Krzysztof Kozlowski
2022-11-03 13:39 ` Michael Tretter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsf0r05z.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=git@amd.com \
    --cc=harini.katakam@amd.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.tretter@pengutronix.de \
    --cc=michal.simek@xilinx.com \
    --cc=radhey.shyam.pandey@amd.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox