From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Eirin Nya <nyanpasu256@gmail.com>, linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Input: Fix incorrectly halved touchpad range on ELAN v3 touchpads
Date: Tue, 11 Oct 2022 15:19:42 +0200 [thread overview]
Message-ID: <87fsfu33bl.fsf@baylibre.com> (raw)
In-Reply-To: <e4438675-d7f6-02f1-79c0-aa9917db8997@gmail.com>
Hi Eirin,
On Sat, Oct 08, 2022 at 03:38, Eirin Nya <nyanpasu256@gmail.com> wrote:
> On 10/7/22 6:35 AM, Mattijs Korpershoek wrote:
>> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>>
>> ps: please consider using the proper subject line for input subsystem if
>> you need to send again.
>>
>> It should be "Input: elantech - Remove redundant field elantech_data::width
> On 10/7/22 7:06 AM, Mattijs Korpershoek wrote:
>> This seems like a candidate patch for stable kernels as well.
>>
>> Maybe consider adding the following in the commit message footer:
>> Fixes: 28f49616113f ("Input: elantech - add v3 hardware support")
>>
>> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>
> Should I submit a v2 where I change the subject line for all commits
> and add a Fixes: tag to patch 3/3 (or 0/3, not sure), but not change
> the code? Sorry, I'm new to kernel development.
No worries. It's not a very newcomer friendly process. I'm not that
experienced myself but i'll try to help you.
No need to just re-submit a v2 for changing the subject line.
If you do have to send a v2, however, please keep in mind to do the change.
For the Fixes: tag itself, I think it should only be applied on patch
[3/3] since that's the one "actually doing the fix"
The stable maintainers will detect a Fixes: tag and will eventually pick
this up once it lands in linus' tree.
next prev parent reply other threads:[~2022-10-11 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 8:21 [PATCH 0/3] Input: Fix incorrectly halved touchpad range on ELAN v3 touchpads Eirin Nya
2022-09-29 8:21 ` [PATCH 1/3] Input: Remove redundant field elantech_data::y_max Eirin Nya
2022-10-07 13:28 ` Mattijs Korpershoek
2022-09-29 8:21 ` [PATCH 2/3] Input: Remove redundant field elantech_data::width Eirin Nya
2022-10-07 13:35 ` Mattijs Korpershoek
2022-09-29 8:21 ` [PATCH 3/3] Input: Fix incorrectly halved touchpad range on ELAN v3 touchpads Eirin Nya
2022-10-07 14:06 ` Mattijs Korpershoek
2022-10-08 10:38 ` Eirin Nya
2022-10-11 13:19 ` Mattijs Korpershoek [this message]
2022-10-08 16:34 ` Eirin Nya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsfu33bl.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nyanpasu256@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).