* [PATCH v2 1/3] sound: realtek: Add pincfg for ASUS G513 HP jack
2022-09-15 8:09 [PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R Luke D. Jones
@ 2022-09-15 8:09 ` Luke D. Jones
2022-09-15 8:09 ` [PATCH v2 2/3] sound: realtek: Add pincfg for ASUS G533Z " Luke D. Jones
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Luke D. Jones @ 2022-09-15 8:09 UTC (permalink / raw)
To: tiwai; +Cc: linux-kernel, alsa-devel, perex, Luke D. Jones
Fixes up the pincfg for ASUS ROG Strix G513 headphone and mic combo jack
Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
sound/pci/hda/patch_realtek.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index fd630d62b5a0..1485dea712d8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7025,6 +7025,7 @@ enum {
ALC294_FIXUP_ASUS_GU502_HP,
ALC294_FIXUP_ASUS_GU502_PINS,
ALC294_FIXUP_ASUS_GU502_VERBS,
+ ALC294_FIXUP_ASUS_G513_PINS,
ALC285_FIXUP_HP_GPIO_LED,
ALC285_FIXUP_HP_MUTE_LED,
ALC236_FIXUP_HP_GPIO_LED,
@@ -8362,6 +8363,15 @@ static const struct hda_fixup alc269_fixups[] = {
[ALC294_FIXUP_ASUS_GU502_HP] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc294_fixup_gu502_hp,
+ },
+ [ALC294_FIXUP_ASUS_G513_PINS] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x19, 0x03a11050 }, /* front HP mic */
+ { 0x1a, 0x03a11c30 }, /* rear external mic */
+ { 0x21, 0x03211420 }, /* front HP out */
+ { }
+ },
},
[ALC294_FIXUP_ASUS_COEF_1B] = {
.type = HDA_FIXUP_VERBS,
@@ -9314,6 +9324,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1e8e, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401),
+ SND_PCI_QUIRK(0x1043, 0x1e5e, "ASUS ROG Strix G513", ALC294_FIXUP_ASUS_G513_PINS),
SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE", ALC256_FIXUP_ASUS_AIO_GPIO2),
SND_PCI_QUIRK(0x1043, 0x831a, "ASUS P901", ALC269_FIXUP_STEREO_DMIC),
--
2.37.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2 2/3] sound: realtek: Add pincfg for ASUS G533Z HP jack
2022-09-15 8:09 [PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R Luke D. Jones
2022-09-15 8:09 ` [PATCH v2 1/3] sound: realtek: Add pincfg for ASUS G513 HP jack Luke D. Jones
@ 2022-09-15 8:09 ` Luke D. Jones
2022-09-15 8:09 ` [PATCH v2 3/3] sound: realtek: Add quirk for ASUS GA503R laptop Luke D. Jones
2022-09-15 15:56 ` [PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R Takashi Iwai
3 siblings, 0 replies; 7+ messages in thread
From: Luke D. Jones @ 2022-09-15 8:09 UTC (permalink / raw)
To: tiwai; +Cc: linux-kernel, alsa-devel, perex, Luke D. Jones
Fixes up the pincfg for ASUS ROG Strix G15 (G533Z) headphone combo jack
Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
sound/pci/hda/patch_realtek.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 1485dea712d8..a44a55619144 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7026,6 +7026,7 @@ enum {
ALC294_FIXUP_ASUS_GU502_PINS,
ALC294_FIXUP_ASUS_GU502_VERBS,
ALC294_FIXUP_ASUS_G513_PINS,
+ ALC285_FIXUP_ASUS_G533Z_PINS,
ALC285_FIXUP_HP_GPIO_LED,
ALC285_FIXUP_HP_MUTE_LED,
ALC236_FIXUP_HP_GPIO_LED,
@@ -8373,6 +8374,15 @@ static const struct hda_fixup alc269_fixups[] = {
{ }
},
},
+ [ALC285_FIXUP_ASUS_G533Z_PINS] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x14, 0x90170120 },
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC294_FIXUP_ASUS_G513_PINS,
+ },
[ALC294_FIXUP_ASUS_COEF_1B] = {
.type = HDA_FIXUP_VERBS,
.v.verbs = (const struct hda_verb[]) {
@@ -9325,6 +9335,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1e5e, "ASUS ROG Strix G513", ALC294_FIXUP_ASUS_G513_PINS),
+ SND_PCI_QUIRK(0x1043, 0x1c92, "ASUS ROG Strix G15", ALC285_FIXUP_ASUS_G533Z_PINS),
SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE", ALC256_FIXUP_ASUS_AIO_GPIO2),
SND_PCI_QUIRK(0x1043, 0x831a, "ASUS P901", ALC269_FIXUP_STEREO_DMIC),
--
2.37.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2 3/3] sound: realtek: Add quirk for ASUS GA503R laptop
2022-09-15 8:09 [PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R Luke D. Jones
2022-09-15 8:09 ` [PATCH v2 1/3] sound: realtek: Add pincfg for ASUS G513 HP jack Luke D. Jones
2022-09-15 8:09 ` [PATCH v2 2/3] sound: realtek: Add pincfg for ASUS G533Z " Luke D. Jones
@ 2022-09-15 8:09 ` Luke D. Jones
2022-09-15 15:56 ` [PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R Takashi Iwai
3 siblings, 0 replies; 7+ messages in thread
From: Luke D. Jones @ 2022-09-15 8:09 UTC (permalink / raw)
To: tiwai; +Cc: linux-kernel, alsa-devel, perex, Luke D. Jones
The ASUS G15 2022 (GA503R) series laptop has the same node-to-DAC pairs
as early models and the G14, this includes bass speakers which are by
default mapped incorrectly to the 0x06 node.
Add a quirk to use the same DAC pairs as the G14.
Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a44a55619144..52eb31f4166c 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9332,6 +9332,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA502),
SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS),
SND_PCI_QUIRK(0x1043, 0x1e8e, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA401),
+ SND_PCI_QUIRK(0x1043, 0x1c52, "ASUS Zephyrus G15 2022", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1e5e, "ASUS ROG Strix G513", ALC294_FIXUP_ASUS_G513_PINS),
--
2.37.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R
2022-09-15 8:09 [PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R Luke D. Jones
` (2 preceding siblings ...)
2022-09-15 8:09 ` [PATCH v2 3/3] sound: realtek: Add quirk for ASUS GA503R laptop Luke D. Jones
@ 2022-09-15 15:56 ` Takashi Iwai
2022-09-16 8:46 ` Luke Jones
2022-09-18 22:18 ` Luke Jones
3 siblings, 2 replies; 7+ messages in thread
From: Takashi Iwai @ 2022-09-15 15:56 UTC (permalink / raw)
To: Luke D. Jones; +Cc: tiwai, linux-kernel, alsa-devel, perex
On Thu, 15 Sep 2022 10:09:18 +0200,
Luke D. Jones wrote:
>
> This series adds quirks to fix pincfg for the ASUS ROG G513 and G533Z laptops, and adds a mapping
> for the ASUS ROG GA503R to use the previous G15/G14 quirks which fix the DAC mapping.
>
> Changelog:
> V2:
> - Use smallcaps in hex string
> - Chain the G533Z quirk with the G513 quirk as they use the same base pincfg
> - Add the quirk for GA503R series to use GA401 quirk
>
> Luke D. Jones (3):
> sound: realtek: Add pincfg for ASUS G513 HP jack
> sound: realtek: Add pincfg for ASUS G533Z HP jack
> sound: realtek: Add quirk for ASUS GA503R laptop
Now applied all patches, but I corrected the positions of the new
entries to be in the SSID order locally. Also, the subject lines are
adjusted to "ALSA:" prefix.
thanks,
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R
2022-09-15 15:56 ` [PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R Takashi Iwai
@ 2022-09-16 8:46 ` Luke Jones
2022-09-18 22:18 ` Luke Jones
1 sibling, 0 replies; 7+ messages in thread
From: Luke Jones @ 2022-09-16 8:46 UTC (permalink / raw)
To: Takashi Iwai; +Cc: tiwai, linux-kernel, alsa-devel, perex
Thanks Takashi,
On Thu, 2022-09-15 at 17:56 +0200, Takashi Iwai wrote:
> On Thu, 15 Sep 2022 10:09:18 +0200,
> Luke D. Jones wrote:
> >
> > This series adds quirks to fix pincfg for the ASUS ROG G513 and
> > G533Z laptops, and adds a mapping
> > for the ASUS ROG GA503R to use the previous G15/G14 quirks which
> > fix the DAC mapping.
> >
> > Changelog:
> > V2:
> > - Use smallcaps in hex string
> > - Chain the G533Z quirk with the G513 quirk as they use the same
> > base pincfg
> > - Add the quirk for GA503R series to use GA401 quirk
> >
> > Luke D. Jones (3):
> > sound: realtek: Add pincfg for ASUS G513 HP jack
> > sound: realtek: Add pincfg for ASUS G533Z HP jack
> > sound: realtek: Add quirk for ASUS GA503R laptop
>
> Now applied all patches, but I corrected the positions of the new
> entries to be in the SSID order locally. Also, the subject lines are
> adjusted to "ALSA:" prefix.
>
I'll try to remember this next time. There's bound to be a few more
with next generation of these laptops.
>
> thanks,
>
> Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R
2022-09-15 15:56 ` [PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R Takashi Iwai
2022-09-16 8:46 ` Luke Jones
@ 2022-09-18 22:18 ` Luke Jones
1 sibling, 0 replies; 7+ messages in thread
From: Luke Jones @ 2022-09-18 22:18 UTC (permalink / raw)
To: Takashi Iwai; +Cc: tiwai, linux-kernel, alsa-devel, perex
On Thu, 2022-09-15 at 17:56 +0200, Takashi Iwai wrote:
> On Thu, 15 Sep 2022 10:09:18 +0200,
> Luke D. Jones wrote:
> >
> > This series adds quirks to fix pincfg for the ASUS ROG G513 and
> > G533Z laptops, and adds a mapping
> > for the ASUS ROG GA503R to use the previous G15/G14 quirks which
> > fix the DAC mapping.
> >
> > Changelog:
> > V2:
> > - Use smallcaps in hex string
> > - Chain the G533Z quirk with the G513 quirk as they use the same
> > base pincfg
> > - Add the quirk for GA503R series to use GA401 quirk
> >
> > Luke D. Jones (3):
> > sound: realtek: Add pincfg for ASUS G513 HP jack
> > sound: realtek: Add pincfg for ASUS G533Z HP jack
> > sound: realtek: Add quirk for ASUS GA503R laptop
>
> Now applied all patches, but I corrected the positions of the new
> entries to be in the SSID order locally. Also, the subject lines are
> adjusted to "ALSA:" prefix.
Excellent, many thanks.
>
>
> thanks,
>
> Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread