From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE6E1C00140 for ; Mon, 15 Aug 2022 16:13:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231952AbiHOQNB (ORCPT ); Mon, 15 Aug 2022 12:13:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231182AbiHOQMz (ORCPT ); Mon, 15 Aug 2022 12:12:55 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1626DFF6 for ; Mon, 15 Aug 2022 09:12:54 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 84FA020931; Mon, 15 Aug 2022 16:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1660579973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JNDhL8OgFUz/XeEfNDIxRvrXP4pUtfmRxUz7skNSIcI=; b=mWLAF9BQuy+qUJJPBInA4rW2/ghuJheww5AQH9mj3n+FNe0rEH9h7R+6T8GnWjWfempGrd KA350tUhmu8tpglu56s21Tn/PrgBnPw8SRVZeOpISLjQ45BdKu1O3RTKJsUbQnyIEkyphD 6YHKXMFTiPkspKLUGYiCAX3Zp9gj9S0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1660579973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JNDhL8OgFUz/XeEfNDIxRvrXP4pUtfmRxUz7skNSIcI=; b=xcB5rA8+PcOMmUQUyMNI+AX+oWXK9yDEDOXPd7Uy2h0/zYc2tT+/tC6ANC92B0dxfOvZtm Fo05dNoRepZklfCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5772413A93; Mon, 15 Aug 2022 16:12:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LkhIFIVw+mKaDwAAMHmgww (envelope-from ); Mon, 15 Aug 2022 16:12:53 +0000 Date: Mon, 15 Aug 2022 18:12:52 +0200 Message-ID: <87fshxzdrv.wl-tiwai@suse.de> From: Takashi Iwai To: Stefan Binding Cc: Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH v1] ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties In-Reply-To: <20220815152844.462229-1-sbinding@opensource.cirrus.com> References: <20220815152844.462229-1-sbinding@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Aug 2022 17:28:44 +0200, Stefan Binding wrote: > > For devices which use HID CSC3551, correct ACPI _DSD properties are > required to be able support those systems. > Add error message to clarify this. > > Signed-off-by: Stefan Binding > --- > sound/pci/hda/cs35l41_hda.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c > index 129bffb431c2..b9d94f3a5b99 100644 > --- a/sound/pci/hda/cs35l41_hda.c > +++ b/sound/pci/hda/cs35l41_hda.c > @@ -1163,6 +1163,11 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd > hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH; > hw_cfg->gpio1.valid = true; > } else { > + /* > + * Note: CLSA010(0/1) are special cases which use a slightly different design. > + * All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be supported. > + */ > + dev_err(cs35l41->dev, "Error: ACPI _DSD Properties are missing for HID %s.", hid); A newline is missing at the end of the string? Takashi