From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: menglong8.dong@gmail.com, edumazet@google.com
Cc: rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org,
pabeni@redhat.com, benbjiang@tencent.com, flyingpeng@tencent.com,
imagedong@tencent.com, kafai@fb.com, talalahmad@google.com,
keescook@chromium.org, mengensun@tencent.com,
dongli.zhang@oracle.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: tcp: add skb drop reasons to route_req()
Date: Thu, 28 Apr 2022 15:22:04 +0200 [thread overview]
Message-ID: <87fslxgx6r.fsf@toke.dk> (raw)
In-Reply-To: <20220428073340.224391-3-imagedong@tencent.com>
menglong8.dong@gmail.com writes:
> From: Menglong Dong <imagedong@tencent.com>
>
> Add skb drop reasons to the route_req() in struct tcp_request_sock_ops.
> Following functions are involved:
>
> tcp_v4_route_req()
> tcp_v6_route_req()
> subflow_v4_route_req()
> subflow_v6_route_req()
>
> And the new reason SKB_DROP_REASON_SECURITY is added, which is used when
> skb is dropped by LSM.
Could we maybe pick a slightly less generic name? If I saw
"SKB_DROP_REASON_SECURITY" my first thought would be something related
to *network* security, like a firewall. Maybe just SKB_DROP_REASON_LSM?
-Toke
next prev parent reply other threads:[~2022-04-28 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 7:33 [PATCH net-next v2 0/2] net: tcp: add skb drop reasons to connect request menglong8.dong
2022-04-28 7:33 ` [PATCH net-next v2 1/2] net: tcp: add skb drop reasons to tcp " menglong8.dong
2022-04-28 7:33 ` [PATCH net-next v2 2/2] net: tcp: add skb drop reasons to route_req() menglong8.dong
2022-04-28 13:22 ` Toke Høiland-Jørgensen [this message]
2022-04-29 1:27 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fslxgx6r.fsf@toke.dk \
--to=toke@redhat.com \
--cc=benbjiang@tencent.com \
--cc=davem@davemloft.net \
--cc=dongli.zhang@oracle.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=flyingpeng@tencent.com \
--cc=imagedong@tencent.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mengensun@tencent.com \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=talalahmad@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox