From: Thomas Gleixner <tglx@linutronix.de>
To: Oleg Nesterov <oleg@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Matt Fleming <matt@codeblueprint.co.uk>
Subject: Re: [PATCH] signal: Allow RT tasks to cache one sigqueue struct
Date: Thu, 04 Mar 2021 22:14:26 +0100 [thread overview]
Message-ID: <87ft1a62q5.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20210303153732.GC28955@redhat.com>
On Wed, Mar 03 2021 at 16:37, Oleg Nesterov wrote:
> On 03/03, Sebastian Andrzej Siewior wrote:
>> +static void __sigqueue_cache_or_free(struct sigqueue *q)
>> +{
>> + struct user_struct *up;
>> +
>> + if (q->flags & SIGQUEUE_PREALLOC)
>> + return;
>> +
>> + up = q->user;
>> + if (atomic_dec_and_test(&up->sigpending))
>> + free_uid(up);
>> + if (!task_is_realtime(current) || !sigqueue_add_cache(current, q))
>> + kmem_cache_free(sigqueue_cachep, q);
>> +}
>
> Well, this duplicates __sigqueue_free... Do we really need the new helper?
> What if we simply change __sigqueue_free() to do sigqueue_add_cache() if
> task_is_realtime() && !PF_EXITING ? This too can simplify the patch...
Need to stare at all callers of __sigqueue_free() whether they are
really happy about this. Even if not, this surely can be deduplicated.
Thanks,
tglx
next prev parent reply other threads:[~2021-03-04 21:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 14:20 [PATCH] signal: Allow RT tasks to cache one sigqueue struct Sebastian Andrzej Siewior
2021-03-03 15:37 ` Oleg Nesterov
2021-03-04 21:10 ` Thomas Gleixner
2021-03-05 10:57 ` Oleg Nesterov
2021-03-04 21:14 ` Thomas Gleixner [this message]
2021-03-03 22:09 ` Eric W. Biederman
2021-03-04 8:11 ` Sebastian Andrzej Siewior
2021-03-04 15:02 ` Thomas Gleixner
2021-03-04 19:04 ` Eric W. Biederman
2021-03-04 20:58 ` Thomas Gleixner
2021-03-10 18:54 ` Thomas Gleixner
2021-03-10 21:57 ` Eric W. Biederman
2021-03-10 23:56 ` Thomas Gleixner
2021-03-11 12:45 ` Thomas Gleixner
2021-03-11 14:20 ` Thomas Gleixner
2021-03-11 16:32 ` Eric W. Biederman
2021-03-04 19:01 ` Eric W. Biederman
[not found] <draft-874khk5yed.fsf@nanos.tec.linutronix.de>
2021-03-10 8:57 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft1a62q5.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox