From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E1E3C433DF for ; Mon, 18 May 2020 10:01:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C31F20801 for ; Mon, 18 May 2020 10:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726993AbgERKBs (ORCPT ); Mon, 18 May 2020 06:01:48 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:50097 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726918AbgERKBr (ORCPT ); Mon, 18 May 2020 06:01:47 -0400 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 6F727200017; Mon, 18 May 2020 10:01:45 +0000 (UTC) From: Gregory CLEMENT To: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org Cc: Thomas Petazzoni Subject: Re: [PATCH v2 0/3] TTY improve n_gsm support In-Reply-To: <20200518084517.2173242-4-gregory.clement@bootlin.com> References: <20200518084517.2173242-1-gregory.clement@bootlin.com> <20200518084517.2173242-4-gregory.clement@bootlin.com> Date: Mon, 18 May 2020 12:01:45 +0200 Message-ID: <87ftbxfto6.fsf@FE-laptop> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, > Hello, > > This series is the second version of patch improving n_gms support > especially with TELIT LE910. However the fix should benefit to any > modem supporting cmux. You can just ignore the emails from this point, I forgot to remove the remaining .patch! Sorry for the noise Gregory > > The first patch is just about improving debugging output. > > The second one removes a tty optimization which make the LE910 hang. > > The last one fixes an issue observed on the LE910 but should benefit > to all the modem. We observed that pretty quickly the transfer done > using the virtual tty were blocked. We found that it was due of a > wakeup to the real tty. Without this fix, the real tty wait for > indefinitely. > > Thanks to Jiri Slaby for the review. > > Changelog: > v1 -> v2: > - don't replace the pr_info by pr_debug > - remove the superfluous printk("\n"); > - use --follow option with git log to find the original commit to fix > - use tty_port_tty_wakeup > - use 'for' loop instead of 'while' > > Gregory > > Gregory CLEMENT (3): > tty: n_gsm: Improve debug output > tty: n_gsm: Fix SOF skipping > tty: n_gsm: Fix waking up upper tty layer when room available > > drivers/tty/n_gsm.c | 48 +++++++++++++++++++++++---------------------- > 1 file changed, 25 insertions(+), 23 deletions(-) > > -- > 2.26.2 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com