From: Jani Nikula <jani.nikula@linux.intel.com>
To: Salvatore Mesoraca <s.mesoraca16@gmail.com>,
linux-kernel@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
kernel-hardening@lists.openwall.com,
David Airlie <airlied@linux.ie>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Kees Cook <keescook@chromium.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Salvatore Mesoraca <s.mesoraca16@gmail.com>
Subject: Re: [PATCH] drm/i915: drop various VLAs in i915_debugfs.c
Date: Wed, 14 Mar 2018 14:17:07 +0200 [thread overview]
Message-ID: <87fu52n96k.fsf@intel.com> (raw)
In-Reply-To: <1520970688-19683-1-git-send-email-s.mesoraca16@gmail.com>
On Tue, 13 Mar 2018, Salvatore Mesoraca <s.mesoraca16@gmail.com> wrote:
> Avoid 3 VLAs[1] by using real constant expressions instead of variables.
> The compiler should be able to optimize the original code and avoid using
> any actual VLAs. Anyway this change is useful because it will avoid a false
> positives with -Wvla, it might also help the compiler generating better
> code.
Thanks for your patch. However, Chris beat you to it with:
7aa0b14ede64 ("drm/i915: Remove variable length arrays from sseu debugfs
printers")
as well as adding -Wvla to our subdir-ccflags-y to prevent more from
cropping up:
c5c2b11894f4 ("drm/i915: Warn against variable length arrays")
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2018-03-14 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 19:51 [PATCH] drm/i915: drop various VLAs in i915_debugfs.c Salvatore Mesoraca
2018-03-14 12:17 ` Jani Nikula [this message]
2018-03-14 12:41 ` Salvatore Mesoraca
2018-03-14 12:27 ` Joonas Lahtinen
2018-03-14 12:43 ` Salvatore Mesoraca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu52n96k.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=s.mesoraca16@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox