linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Wanpeng Li" <wanpeng.li@hotmail.com>,
	"Jim Mattson" <jmattson@google.com>
Subject: Re: [PATCH] KVM: VMX: Cache IA32_DEBUGCTL in memory
Date: Wed, 29 Nov 2017 10:20:51 -0800	[thread overview]
Message-ID: <87fu8xj69o.fsf@linux.intel.com> (raw)
In-Reply-To: <1511935673-7371-1-git-send-email-wanpeng.li@hotmail.com> (Wanpeng Li's message of "Tue, 28 Nov 2017 22:07:53 -0800")

Wanpeng Li <kernellwp@gmail.com> writes:

> From: Wanpeng Li <wanpeng.li@hotmail.com>
>
> MSR_IA32_DEBUGCTLMSR is zeroed on VMEXIT, so it is saved/restored 
> each time during world switch. Jim from Google pointed out that 
> when running schbench in L2, vmx_vcpu_run will occupy 4% cpu time, 
> and the 25% of vmx_vcpu_run cpu time is occupied by get_debugctlmsr(). 
> This patch caches the host IA32_DEBUGCTL MSR and saves/restores 
> the host IA32_DEBUGCTL msr when guest/host switches to avoid to 
> save/restore each time during world switch.

FWIW i've seen this too on L2 profiles.

But I haven't looked too closely, but I suspect you'll clobber global
kernel debugger state this way.

You would at least need some interface for KDB etc. to invalidate
your cache.

-Andi

  parent reply	other threads:[~2017-11-29 18:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29  6:07 [PATCH] KVM: VMX: Cache IA32_DEBUGCTL in memory Wanpeng Li
2017-11-29  8:48 ` Paolo Bonzini
2017-11-29  8:51   ` Wanpeng Li
2017-11-29  9:13     ` Paolo Bonzini
2017-11-29  9:20       ` Wanpeng Li
2017-11-29 18:20 ` Andi Kleen [this message]
2017-11-29 19:05   ` Jim Mattson
2017-11-29 20:56     ` Andi Kleen
2017-11-29 22:26   ` Paolo Bonzini
2017-11-29 22:45     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fu8xj69o.fsf@linux.intel.com \
    --to=ak@linux.intel.com \
    --cc=jmattson@google.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).