From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758004AbdJMM25 (ORCPT ); Fri, 13 Oct 2017 08:28:57 -0400 Received: from alexa-out.qualcomm.com ([129.46.98.28]:60112 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753231AbdJMM2z (ORCPT ); Fri, 13 Oct 2017 08:28:55 -0400 X-IronPort-AV: E=Sophos;i="5.43,370,1503385200"; d="scan'208";a="6319144" X-IronPort-AV: E=McAfee;i="5900,7806,8682"; a="1442303295" X-MGA-submission: =?us-ascii?q?MDFWp/tVUz16SXgcgPZ7UAKLbw4Jf+2RAkAJNm?= =?us-ascii?q?KU47rGQVOvR5ccr5kpyDobedxYFd4aUyM8wyVtKarDIC5x1dO/WuoGd9?= =?us-ascii?q?6JtN3tJRZHao/FHu0CaaW79qTPIsyVSElVKjZyZA+8YBUAPeIx9YAl8y?= =?us-ascii?q?BS?= From: Kalle Valo To: Christos Gkekas CC: "ath10k@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ath10k: spectral: Simplify error checking Thread-Topic: [PATCH] ath10k: spectral: Simplify error checking Thread-Index: AQHTQOZkyjyViCUAb0m7CbgoBK4kFg== Date: Fri, 13 Oct 2017 12:28:50 +0000 Message-ID: <87fuannse6.fsf@kamboji.qca.qualcomm.com> References: <1507491026-28690-1-git-send-email-chris.gekas@gmail.com> In-Reply-To: <1507491026-28690-1-git-send-email-chris.gekas@gmail.com> (Christos Gkekas's message of "Sun, 8 Oct 2017 20:30:26 +0100") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9DCT1fs031828 Christos Gkekas writes: > Variable val is unsigned so checking whether it is less than zero is > redundant. > > Signed-off-by: Christos Gkekas > --- > drivers/net/wireless/ath/ath10k/spectral.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net/wireless/ath/ath10k/spectral.c > index dd9cc09..1867937 100644 > --- a/drivers/net/wireless/ath/ath10k/spectral.c > +++ b/drivers/net/wireless/ath/ath10k/spectral.c > @@ -403,10 +403,7 @@ static ssize_t write_file_spectral_count(struct file *file, > return -EFAULT; > > buf[len] = '\0'; > - if (kstrtoul(buf, 0, &val)) > - return -EINVAL; > - > - if (val < 0 || val > 255) > + if (kstrtoul(buf, 0, &val) || val > 255) > return -EINVAL; Removing the check for negative is correct but I don't think you are simplifying anything, on the contrary it's harder to read. Please keep the two if statements separate. -- Kalle Valo