From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751196AbdEaKGG (ORCPT ); Wed, 31 May 2017 06:06:06 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35803 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbdEaKGB (ORCPT ); Wed, 31 May 2017 06:06:01 -0400 From: Gregory CLEMENT To: Rob Herring Cc: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Russell King , Nadav Haklai , Kostya Porotchkin , Neta Zur Hershkovits , Marcin Wojtas , Omri Itach , Shadi Ammouri Subject: Re: [PATCH 3/6] gpio: dt-bindings: Add documentation for gpio controllers on Armada 7K/8K References: <306395ff39de3d3d3c8f55e5da4de8def29ae8d1.1495210061.git-series.gregory.clement@free-electrons.com> <20170530222907.ysx53p3efyxudyqp@rob-hp-laptop> Date: Wed, 31 May 2017 12:05:49 +0200 In-Reply-To: <20170530222907.ysx53p3efyxudyqp@rob-hp-laptop> (Rob Herring's message of "Tue, 30 May 2017 17:29:07 -0500") Message-ID: <87fufltk76.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On mer., mai 31 2017, Rob Herring wrote: >> >> Required properties: >> >> -- compatible : Should be "marvell,orion-gpio", "marvell,mv78200-gpio" >> - or "marvell,armadaxp-gpio". "marvell,orion-gpio" should be used for >> - Orion, Kirkwood, Dove, Discovery (except MV78200) and Armada >> - 370. "marvell,mv78200-gpio" should be used for the Discovery >> - MV78200. "marvel,armadaxp-gpio" should be used for all Armada XP >> - SoCs (MV78230, MV78260, MV78460). >> +- compatible : Should be "marvell,orion-gpio", "marvell,mv78200-gpio", >> + "marvell,armadaxp-gpio" or "marvell,armada-8k-gpio". >> + >> + "marvell,orion-gpio" should be used for Orion, Kirkwood, Dove, >> + Discovery (except MV78200) and Armada 370. "marvell,mv78200-gpio" >> + should be used for the Discovery MV78200. >> + >> + "marvel,armadaxp-gpio" should be used for all Armada XP SoCs >> + (MV78230, MV78260, MV78460). >> + >> + "marvell,armada-8k-gpio" should be used for the Armada 7K and 8K >> + SoCs (either from AP or CP), see >> + Documentation/devicetree/bindings/arm/marvell/cp110-system-controller0.txt >> + and >> + Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt >> + for specific details about the offset property. >> >> - reg: Address and length of the register set for the device. Only one >> entry is expected, except for the "marvell,armadaxp-gpio" variant >> for which two entries are expected: one for the general registers, >> - one for the per-cpu registers. >> + one for the per-cpu registers. Not used for marvell,armada-8k-gpio. > > Why can't use you use reg instead of offset? I looked for how the other syscon user did, and I found the offset usage. So I assumed it was the way to do it. But if you wan I can use a reg property. Gregory > > Rob -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com