From: "Bjørn Mork" <bjorn@mork.no>
To: Jim Baxter <jim_baxter@mentor.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Oliver Neukum <oliver@neukum.org>
Subject: Re: [PATCH V1 1/1] net: cdc_ncm: Fix TX zero padding
Date: Thu, 04 May 2017 23:01:01 +0200 [thread overview]
Message-ID: <87fugkfib6.fsf@miraculix.mork.no> (raw)
In-Reply-To: <1493926895-14556-2-git-send-email-jim_baxter@mentor.com> (Jim Baxter's message of "Thu, 4 May 2017 20:41:35 +0100")
Jim Baxter <jim_baxter@mentor.com> writes:
> The zero padding that is added to NTB's does
> not zero the memory correctly.
> This is because the skb_put modifies the value
> of skb_out->len which results in the memset
> command not setting any memory to zero as
> (ctx->tx_max - skb_out->len) == 0.
>
> I have resolved this by storing the size of
> the memory to be zeroed before the skb_put
> and using this in the memset call.
>
> Signed-off-by: Jim Baxter <jim_baxter@mentor.com>
Ouch! Thanks for finding this. This should go to the stable queue as
well.
Reviewed-by: Bjørn Mork <bjorn@mork.no>
next prev parent reply other threads:[~2017-05-04 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 19:41 [PATCH V1 0/1] net: cdc_ncm: Fix TX zero padding Jim Baxter
2017-05-04 19:41 ` [PATCH V1 1/1] " Jim Baxter
2017-05-04 21:01 ` Bjørn Mork [this message]
2017-05-08 10:49 ` Baxter, Jim
2017-05-08 11:08 ` Bjørn Mork
2017-05-08 12:02 ` Baxter, Jim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fugkfib6.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=jim_baxter@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox