Re: [PATCH v2] usb: gadget: legacy gadgets are optional

[Felipe Balbi <balbi@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]


Hi,

Romain Izard <romain.izard.pro@gmail.com> writes:
> Hello Felipe,
>
> 2017-03-10 10:15 GMT+01:00 Felipe Balbi <balbi@kernel.org>:
>>
>> Hi,
>>
>> Romain Izard <romain.izard.pro@gmail.com> writes:
>>> With commit "usb: gadget: don't couple configfs to legacy gadgets"
>>> it is possible to build a modular kernel with both built-in configfs
>>> support and modular legacy gadget drivers.
>>>
>>> But when building a kernel without modules, it is also necessary to be
>>> able to build with configfs but without any legacy gadget driver.
>>>
>>> Mark the choice for legacy gadget drivers as optional.
>>>
>>> Fixes: bc49d1d17dcf ("usb: gadget: don't couple configfs to legacy gadgets")
>>> Cc: <stable@vger.kernel.org> # 4.9+
>>
>> this is *NOT* a fix since this requirement didn't exist before.
>
> It worked in 4.1, as a non-modular kernel would only have a single entry
> from the USB gadget driver choice option, and USB_CONFIGFS was one of
> those.

but it wasn't a requirement :-)

> When I moved on to 4.9, this configuration could not be selected anymore.

you could've let us know you needed that working :-) That changed quite
a while back :-) Anyway, I get what you mean. I'll take patch for v4.12
with the stable tag in it.

>>> @@ -476,6 +477,12 @@ choice
>>>         not be able work with that controller, or might need to implement
>>>         a less common variant of a device class protocol.
>>>
>>> +       The available choices each represent a single precomposed USB
>>> +       gadget configuration. In the device model, each option contains
>>> +       both the device instanciation as a child for a USB gadget
>>> +       controller, and the relevant drivers for each function declared
>>> +       by the device.
>>
>> unrelated change
>
> I'll split this.

thank you

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]