public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: "Lee\, Chun-Yi" <joeyli.kernel@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Lee\, Chun-Yi" <jlee@suse.com>
Subject: Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family
Date: Mon, 29 Aug 2016 12:11:59 +0200	[thread overview]
Message-ID: <87fupnx4sw.fsf@miraculix.mork.no> (raw)
In-Reply-To: <1472464553-9922-1-git-send-email-jlee@suse.com> (Chun-Yi Lee's message of "Mon, 29 Aug 2016 17:55:53 +0800")

"Lee, Chun-Yi" <joeyli.kernel@gmail.com> writes:

> The AMW0_GUID1 wmi is not only found on Acer family but also other
> machines like Lenovo, Fujitsu and Medion. In the past days, acer-wmi
> driver handled those non-Acer machines by quirks list.
>
> But actually acer-wmi driver was loaded on any machines that have
> AMW0_GUID1. This behavior is strange because those machines should
> be supported by appropriate wmi drivers. e.g. fujitsu-laptop,
> ideapad-laptop.
>
> So, This patch adds the logic to check the machine that has AMW0_GUID1
> should be in Acer/Packard Bell/Gateway white list. But, it still keeps
> the quirk list of those supported non-acer machines for backward
> compatible.

Works fine for me on a Lenovo Thinkpad X1 Carbon 4th gen.  Thanks.

Bogus accelerometer device without patch:

  acer_wmi: Acer Laptop ACPI-WMI Extras
  input: Acer BMA150 accelerometer as /devices/virtual/input/input16

With patch:

  acer_wmi: Acer Laptop ACPI-WMI Extras
  acer_wmi: Unsupported machine has AMW0_GUID1, unable to load


So if you want it:

Tested-by: Bjørn Mork <bjorn@mork.no>

  reply	other threads:[~2016-08-29 10:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29  9:55 [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family Lee, Chun-Yi
2016-08-29 10:11 ` Bjørn Mork [this message]
2016-08-29 12:55   ` joeyli
  -- strict thread matches above, loose matches on Subject: below --
2016-10-12 23:32 Lee, Chun-Yi
2016-11-01  4:30 Lee, Chun-Yi
2016-11-03  3:40 ` Anthony Wong
2016-11-03  4:14   ` joeyli
2016-11-05 18:27   ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fupnx4sw.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=dvhart@infradead.org \
    --cc=jlee@suse.com \
    --cc=joeyli.kernel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox