From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753838AbcBZHYW (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Feb 2016 02:24:22 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:36634 "EHLO
	mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753763AbcBZHYT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Feb 2016 02:24:19 -0500
From: Holger Schurig <holgerschurig@gmail.com>
To: Pankaj Dev <pankaj.dev@st.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org, mturquette@linaro.org, kernel@stlinux.com,
        sboyd@codeaurora.org, laurent.meunier@st.com, lee.jones@linaro.org,
        maxime.coquelin@st.com
Subject: Re: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-parent
In-Reply-To: <1456454309-25037-1-git-send-email-pankaj.dev@st.com> (Pankaj
	Dev's message of "Fri, 26 Feb 2016 08:08:29 +0530")
References: <1456454309-25037-1-git-send-email-pankaj.dev@st.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
Date: Fri, 26 Feb 2016 08:24:15 +0100
Message-ID: <87fuwg9bog.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Pankaj Dev <pankaj.dev@st.com> writes:

> 1. clk_set_rate : Set new rate to value. Reading returns the
> current rate

If you can use this to set *and* read it, then "_set_" shouldn't be in
the name.

What is wrong with using the existing "clk_rate" for reading/setting the
rate?