public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Minfei Huang <mnfhuang@gmail.com>
Cc: akpm@linux-foundation.org, dyoung@redhat.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	mhuang@redhat.com
Subject: Re: [PATCH] kexec: Add prefix "kexec" to output message
Date: Sun, 13 Sep 2015 11:52:41 -0500	[thread overview]
Message-ID: <87fv2il0rq.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <1442128512-32578-1-git-send-email-mnfhuang@gmail.com> (Minfei Huang's message of "Sun, 13 Sep 2015 15:15:12 +0800")

Minfei Huang <mnfhuang@gmail.com> writes:

> kexec output message misses the prefix "kexec", when Dave Young split
> the kexec code. To keep the same format, add the prefix "kexec" to
> output message.

What of kexec_core? What of the messages that already have a prefix?

Eric

> Following is the format of output message now.
> [  140.290795] SYSC_kexec_load: hello, world
>
> Ideally, the format of output message likes below.
> [  140.291534] kexec: sanity_check_segment_list: hello, world
>
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> ---
>  kernel/kexec.c      | 2 ++
>  kernel/kexec_file.c | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 4c5edc3..15351ba 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -6,6 +6,8 @@
>   * Version 2.  See the file COPYING for more details.
>   */
>  
> +#define pr_fmt(fmt)	"kexec: " fmt
> +
>  #include <linux/capability.h>
>  #include <linux/mm.h>
>  #include <linux/file.h>
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index 6a9a3f2..b1ad01b 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -9,6 +9,8 @@
>   * Version 2.  See the file COPYING for more details.
>   */
>  
> +#define pr_fmt(fmt)	"kexec: " fmt
> +
>  #include <linux/capability.h>
>  #include <linux/mm.h>
>  #include <linux/file.h>

  reply	other threads:[~2015-09-13 16:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13  7:15 [PATCH] kexec: Add prefix "kexec" to output message Minfei Huang
2015-09-13 16:52 ` Eric W. Biederman [this message]
2015-09-14  7:50   ` Minfei Huang
2015-09-14  8:44     ` Dave Young
2015-09-15  3:08       ` Minfei Huang
2015-09-22 16:07         ` Minfei Huang
2015-09-23  1:37           ` Dave Young
2015-09-23  2:49             ` Baoquan He
2015-09-23  5:14               ` Minfei Huang
2015-09-23  5:26                 ` Baoquan He
2015-09-23  5:44                   ` Minfei Huang
2015-09-23  7:01               ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fv2il0rq.fsf@x220.int.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=akpm@linux-foundation.org \
    --cc=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhuang@redhat.com \
    --cc=mnfhuang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox