From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: sebastian.hesselbarth@gmail.com,
ezequiel.garcia@free-electrons.com, dwmw2@infradead.org,
computersforpeace@gmail.com, zmxu@marvell.com,
boris.brezillon@free-electrons.com, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, jszhang@marvell.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] Documentation: bindings: document the clocks for pxa3xx-nand
Date: Wed, 03 Jun 2015 21:12:28 +0200 [thread overview]
Message-ID: <87fv6861yb.fsf@belgarion.home> (raw)
In-Reply-To: <1433266351-22587-3-git-send-email-antoine.tenart@free-electrons.com> (Antoine Tenart's message of "Tue, 2 Jun 2015 19:32:26 +0200")
Antoine Tenart <antoine.tenart@free-electrons.com> writes:
> The pxa3xx nand driver requires at least one clock to probe correctly.
> A second one, named 'ecc' can be specified if needed. Add the
> corresponding documentation.
Is it mandatory, really ?
The code does :
info->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(info->clk)) {
dev_err(&pdev->dev, "failed to get nand clock\n");
return PTR_ERR(info->clk);
}
info->clk can very well be NULL, can't it ?
Cheers.
--
Robert
next prev parent reply other threads:[~2015-06-03 19:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 17:32 [PATCH 0/7] ARM: berlin: nand support Antoine Tenart
2015-06-02 17:32 ` [PATCH 1/7] mtd: pxa3xx_nand: add a non mandatory ECC clock Antoine Tenart
2015-06-03 19:23 ` Robert Jarzmik
2015-06-02 17:32 ` [PATCH 2/7] Documentation: bindings: document the clocks for pxa3xx-nand Antoine Tenart
2015-06-03 19:12 ` Robert Jarzmik [this message]
2015-06-02 17:32 ` [PATCH 3/7] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller Antoine Tenart
2015-06-02 17:32 ` [PATCH 4/7] Documentation: bindings: add the Berlin nand controller compatible Antoine Tenart
2015-06-02 17:32 ` [PATCH 5/7] mtd: nand: let Marvell Berlin SoCs select the pxa3xx driver Antoine Tenart
2015-06-02 17:32 ` [PATCH 6/7] ARM: berlin: add BG2Q node for the nand Antoine Tenart
2015-06-02 17:32 ` [PATCH 7/7] ARM: berlin: enable flash on the BG2Q DMP Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv6861yb.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=antoine.tenart@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox