* [PATCH 10/19] ath6kl: fix %d confusingly prefixed with 0x in format strings
@ 2014-08-04 0:19 Hans Wennborg
2014-08-14 12:38 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: Hans Wennborg @ 2014-08-04 0:19 UTC (permalink / raw)
To: linville, linux-wireless, linux-kernel; +Cc: Hans Wennborg
Signed-off-by: Hans Wennborg <hans@hanshq.net>
---
drivers/net/wireless/ath/ath6kl/init.c | 2 +-
drivers/net/wireless/ath/ath6kl/main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
index fffd523..91af845 100644
--- a/drivers/net/wireless/ath/ath6kl/init.c
+++ b/drivers/net/wireless/ath/ath6kl/init.c
@@ -1049,7 +1049,7 @@ static int ath6kl_fetch_fw_apin(struct ath6kl *ar, const char *name)
ar->hw.reserved_ram_size = le32_to_cpup(val);
ath6kl_dbg(ATH6KL_DBG_BOOT,
- "found reserved ram size ie 0x%d\n",
+ "found reserved ram size ie 0x%x\n",
ar->hw.reserved_ram_size);
break;
case ATH6KL_FW_IE_CAPABILITIES:
diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
index 21516bc..933aef0 100644
--- a/drivers/net/wireless/ath/ath6kl/main.c
+++ b/drivers/net/wireless/ath/ath6kl/main.c
@@ -225,7 +225,7 @@ int ath6kl_diag_write32(struct ath6kl *ar, u32 address, __le32 value)
ret = ath6kl_hif_diag_write32(ar, address, value);
if (ret) {
- ath6kl_err("failed to write 0x%x during diagnose window to 0x%d\n",
+ ath6kl_err("failed to write 0x%x during diagnose window to 0x%x\n",
address, value);
return ret;
}
--
2.0.0.526.g5318336
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 10/19] ath6kl: fix %d confusingly prefixed with 0x in format strings
2014-08-04 0:19 [PATCH 10/19] ath6kl: fix %d confusingly prefixed with 0x in format strings Hans Wennborg
@ 2014-08-14 12:38 ` Kalle Valo
2014-08-17 21:57 ` [PATCH 1/1] " Hans Wennborg
0 siblings, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2014-08-14 12:38 UTC (permalink / raw)
To: Hans Wennborg; +Cc: linville, linux-wireless, linux-kernel, ath6kl
Hans Wennborg <hans@hanshq.net> writes:
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
> ---
> drivers/net/wireless/ath/ath6kl/init.c | 2 +-
> drivers/net/wireless/ath/ath6kl/main.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
> index fffd523..91af845 100644
> --- a/drivers/net/wireless/ath/ath6kl/init.c
> +++ b/drivers/net/wireless/ath/ath6kl/init.c
> @@ -1049,7 +1049,7 @@ static int ath6kl_fetch_fw_apin(struct ath6kl *ar, const char *name)
> ar->hw.reserved_ram_size = le32_to_cpup(val);
>
> ath6kl_dbg(ATH6KL_DBG_BOOT,
> - "found reserved ram size ie 0x%d\n",
> + "found reserved ram size ie 0x%x\n",
> ar->hw.reserved_ram_size);
Actually the original intent here was to use %d.
> diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
> index 21516bc..933aef0 100644
> --- a/drivers/net/wireless/ath/ath6kl/main.c
> +++ b/drivers/net/wireless/ath/ath6kl/main.c
> @@ -225,7 +225,7 @@ int ath6kl_diag_write32(struct ath6kl *ar, u32 address, __le32 value)
> ret = ath6kl_hif_diag_write32(ar, address, value);
>
> if (ret) {
> - ath6kl_err("failed to write 0x%x during diagnose window to 0x%d\n",
> + ath6kl_err("failed to write 0x%x during diagnose window to 0x%x\n",
> address, value);
This is ok.
--
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/1] ath6kl: fix %d confusingly prefixed with 0x in format strings
2014-08-14 12:38 ` Kalle Valo
@ 2014-08-17 21:57 ` Hans Wennborg
2014-08-25 8:20 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: Hans Wennborg @ 2014-08-17 21:57 UTC (permalink / raw)
To: kvalo, linville, linux-wireless, linux-kernel, ath6kl; +Cc: Hans Wennborg
Signed-off-by: Hans Wennborg <hans@hanshq.net>
---
drivers/net/wireless/ath/ath6kl/init.c | 2 +-
drivers/net/wireless/ath/ath6kl/main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
index fffd523..6e473fa 100644
--- a/drivers/net/wireless/ath/ath6kl/init.c
+++ b/drivers/net/wireless/ath/ath6kl/init.c
@@ -1049,7 +1049,7 @@ static int ath6kl_fetch_fw_apin(struct ath6kl *ar, const char *name)
ar->hw.reserved_ram_size = le32_to_cpup(val);
ath6kl_dbg(ATH6KL_DBG_BOOT,
- "found reserved ram size ie 0x%d\n",
+ "found reserved ram size ie %d\n",
ar->hw.reserved_ram_size);
break;
case ATH6KL_FW_IE_CAPABILITIES:
diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
index 21516bc..933aef0 100644
--- a/drivers/net/wireless/ath/ath6kl/main.c
+++ b/drivers/net/wireless/ath/ath6kl/main.c
@@ -225,7 +225,7 @@ int ath6kl_diag_write32(struct ath6kl *ar, u32 address, __le32 value)
ret = ath6kl_hif_diag_write32(ar, address, value);
if (ret) {
- ath6kl_err("failed to write 0x%x during diagnose window to 0x%d\n",
+ ath6kl_err("failed to write 0x%x during diagnose window to 0x%x\n",
address, value);
return ret;
}
--
2.1.0.rc2.206.gedb03e5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-25 8:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-04 0:19 [PATCH 10/19] ath6kl: fix %d confusingly prefixed with 0x in format strings Hans Wennborg
2014-08-14 12:38 ` Kalle Valo
2014-08-17 21:57 ` [PATCH 1/1] " Hans Wennborg
2014-08-25 8:20 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox