From: Namhyung Kim <namhyung@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Oleg Nesterov <oleg@redhat.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Hyeoncheol Lee <cheol.lee@lge.com>,
"zhangwei\(Jovi\)" <jovi.zhangwei@huawei.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Hemant Kumar <hkshaw@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes
Date: Mon, 16 Dec 2013 17:40:23 +0900 [thread overview]
Message-ID: <87fvptgpe0.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <52AEB87D.6020507@hitachi.com> (Masami Hiramatsu's message of "Mon, 16 Dec 2013 17:23:25 +0900")
Hi Masami,
On Mon, 16 Dec 2013 17:23:25 +0900, Masami Hiramatsu wrote:
> (2013/12/16 13:32), Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>>
>> Move existing functions to trace_kprobe.c and add NULL entries to the
>> uprobes fetch type table. I don't make them static since some generic
>> routines like update/free_XXX_fetch_param() require pointers to the
>> functions.
>>
>> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>> Cc: Oleg Nesterov <oleg@redhat.com>
>> Cc: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
>> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> This looks good for me :)
>
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>
> And now all of this series has been reviewed/acked by me!
Thank you so much for your review! :)
Thanks,
Namhyung
next prev parent reply other threads:[~2013-12-16 8:40 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 4:31 [PATCHSET 00/17] tracing/uprobes: Add support for more fetch methods (v9) Namhyung Kim
2013-12-16 4:32 ` [PATCH 01/17] tracing/uprobes: Fix documentation of uprobe registration syntax Namhyung Kim
2013-12-16 4:32 ` [PATCH 02/17] tracing/probes: Fix basic print type functions Namhyung Kim
2013-12-16 4:32 ` [PATCH 03/17] tracing/kprobes: Factor out struct trace_probe Namhyung Kim
2013-12-16 4:32 ` [PATCH 04/17] tracing/uprobes: Convert to " Namhyung Kim
2013-12-16 4:32 ` [PATCH 05/17] tracing/kprobes: Move common functions to trace_probe.h Namhyung Kim
2013-12-16 4:32 ` [PATCH 06/17] tracing/probes: Integrate duplicate set_print_fmt() Namhyung Kim
2013-12-16 4:32 ` [PATCH 07/17] tracing/probes: Move fetch function helpers to trace_probe.h Namhyung Kim
2013-12-16 4:32 ` [PATCH 08/17] tracing/probes: Split [ku]probes_fetch_type_table Namhyung Kim
2013-12-16 4:32 ` [PATCH 09/17] tracing/probes: Implement 'stack' fetch method for uprobes Namhyung Kim
2013-12-16 8:17 ` Masami Hiramatsu
2013-12-16 4:32 ` [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes Namhyung Kim
2013-12-16 8:23 ` Masami Hiramatsu
2013-12-16 8:40 ` Namhyung Kim [this message]
2013-12-17 0:16 ` Namhyung Kim
2013-12-18 20:25 ` Steven Rostedt
2013-12-18 20:34 ` Oleg Nesterov
2013-12-19 8:55 ` Namhyung Kim
2013-12-19 8:54 ` Namhyung Kim
2013-12-18 20:23 ` Steven Rostedt
2013-12-19 7:34 ` Namhyung Kim
2013-12-19 14:18 ` Steven Rostedt
2013-12-20 1:05 ` Namhyung Kim
2013-12-16 4:32 ` [PATCH 11/17] tracing/probes: Add fetch{,_size} member into deref fetch method Namhyung Kim
2013-12-16 4:32 ` [PATCH 12/17] tracing/probes: Implement 'memory' fetch method for uprobes Namhyung Kim
2013-12-16 4:32 ` [PATCH 13/17] tracing/uprobes: Pass 'is_return' to traceprobe_parse_probe_arg() Namhyung Kim
2013-12-16 4:32 ` [PATCH 14/17] tracing/uprobes: Fetch args before reserving a ring buffer Namhyung Kim
2013-12-16 4:32 ` [PATCH 15/17] tracing/uprobes: Add support for full argument access methods Namhyung Kim
2014-01-02 20:58 ` Steven Rostedt
2014-01-02 21:02 ` Steven Rostedt
2014-01-03 1:17 ` Hyeoncheol Lee
2014-01-03 1:53 ` Steven Rostedt
2013-12-16 4:32 ` [PATCH 16/17] uprobes: Allocate ->utask before handler_chain() for tracing handlers Namhyung Kim
2013-12-16 4:32 ` [PATCH 17/17] tracing/uprobes: Add @+file_offset fetch method Namhyung Kim
2013-12-21 5:22 ` [PATCHSET 00/17] tracing/uprobes: Add support for more fetch methods (v9) Steven Rostedt
2013-12-22 12:32 ` Namhyung Kim
2013-12-23 18:00 ` Oleg Nesterov
2013-12-24 8:02 ` Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2013-12-09 6:19 [PATCHSET 00/17] tracing/uprobes: Add support for more fetch methods (v8) Namhyung Kim
2013-12-09 6:19 ` [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes Namhyung Kim
2013-12-10 10:12 ` Masami Hiramatsu
2013-12-11 1:05 ` Namhyung Kim
2013-12-11 1:26 ` Masami Hiramatsu
2013-11-27 6:19 [PATCHSET 00/17] tracing/uprobes: Add support for more fetch methods (v7) Namhyung Kim
2013-11-27 6:19 ` [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvptgpe0.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=cheol.lee@lge.com \
--cc=hkshaw@linux.vnet.ibm.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=namhyung.kim@lge.com \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).