From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752762Ab3LPIk1 (ORCPT ); Mon, 16 Dec 2013 03:40:27 -0500 Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:60478 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751Ab3LPIk0 (ORCPT ); Mon, 16 Dec 2013 03:40:26 -0500 X-AuditID: 9c93016f-b7cc5ae000007121-19-52aebc777720 From: Namhyung Kim To: Masami Hiramatsu Cc: Steven Rostedt , Oleg Nesterov , Srikar Dronamraju , Hyeoncheol Lee , "zhangwei\(Jovi\)" , Arnaldo Carvalho de Melo , Hemant Kumar , LKML , Namhyung Kim Subject: Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes References: <1387168336-13213-1-git-send-email-namhyung@kernel.org> <1387168336-13213-11-git-send-email-namhyung@kernel.org> <52AEB87D.6020507@hitachi.com> Date: Mon, 16 Dec 2013 17:40:23 +0900 In-Reply-To: <52AEB87D.6020507@hitachi.com> (Masami Hiramatsu's message of "Mon, 16 Dec 2013 17:23:25 +0900") Message-ID: <87fvptgpe0.fsf@sejong.aot.lge.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masami, On Mon, 16 Dec 2013 17:23:25 +0900, Masami Hiramatsu wrote: > (2013/12/16 13:32), Namhyung Kim wrote: >> From: Namhyung Kim >> >> Move existing functions to trace_kprobe.c and add NULL entries to the >> uprobes fetch type table. I don't make them static since some generic >> routines like update/free_XXX_fetch_param() require pointers to the >> functions. >> >> Cc: Masami Hiramatsu >> Cc: Srikar Dronamraju >> Cc: Oleg Nesterov >> Cc: zhangwei(Jovi) >> Cc: Arnaldo Carvalho de Melo >> Signed-off-by: Namhyung Kim > > This looks good for me :) > > Acked-by: Masami Hiramatsu > > And now all of this series has been reviewed/acked by me! Thank you so much for your review! :) Thanks, Namhyung