From: Rusty Russell <rusty@rustcorp.com.au>
To: Mathias Krause <minipli@googlemail.com>
Cc: Mathias Krause <minipli@googlemail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] module: don't modify argument of module_kallsyms_lookup_name()
Date: Sun, 16 Jun 2013 12:05:16 +0930 [thread overview]
Message-ID: <87fvwirdej.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1371258778-12655-1-git-send-email-minipli@googlemail.com>
Mathias Krause <minipli@googlemail.com> writes:
> If we pass a pointer to a const string in the form "module:symbol"
> module_kallsyms_lookup_name() will try to split the string at the colon,
> i.e., will try to modify r/o data. That will, in fact, fail on a kernel
> with enabled CONFIG_DEBUG_RODATA.
>
> Avoid modifying the passed string in module_kallsyms_lookup_name(),
> modify find_module_all() instead to pass it the module name length.
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
Applied, thanks.
Cheers,
Rusty.
next prev parent reply other threads:[~2013-06-16 3:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-15 1:12 [PATCH v2] module: don't modify argument of module_kallsyms_lookup_name() Mathias Krause
2013-06-16 2:35 ` Rusty Russell [this message]
2013-06-20 17:40 ` Mathias Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvwirdej.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=minipli@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox