public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Pekka Enberg <penberg@kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH 1/7] perf hists: Separate out hist print functions
Date: Fri, 10 Aug 2012 12:08:13 +0900	[thread overview]
Message-ID: <87fw7vwijm.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20120809191827.GE4084@infradead.org> (Arnaldo Carvalho de Melo's message of "Thu, 9 Aug 2012 16:18:27 -0300")

Hi, Arnaldo

On Thu, 9 Aug 2012 16:18:27 -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Aug 06, 2012 at 05:57:36PM +0900, Namhyung Kim escreveu:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>> 
>> Separate out those functions into ui/hist.c. This is required for
>> upcoming changes.
>
> Isn't it better to further separate it by introducing the ui/stdio/
> directory since these functions use fprintf?
>
Maybe. I agree that general ui code reside on ui/ and front-end
specifics should go to their subdirectories. But not sure for the stdio
case since they'll have very simple code only.

For this case, most of functions would be converted to manipulate a
string buffer like scnprintf and shared by all front-end's as long as
possible - callchain print code needs some more working. But if you
want, I'll separate out actual fprintf's to ui/stdio/.

Thanks,
Namhyung


  reply	other threads:[~2012-08-10  3:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06  8:57 [PATCH 0/7] perf hists: Cleanup hist printing code (v2) Namhyung Kim
2012-08-06  8:57 ` [PATCH 1/7] perf hists: Separate out hist print functions Namhyung Kim
2012-08-09 19:18   ` Arnaldo Carvalho de Melo
2012-08-10  3:08     ` Namhyung Kim [this message]
2012-08-06  8:57 ` [PATCH 2/7] perf hists: Refactor some functions Namhyung Kim
2012-08-06  8:57 ` [PATCH 3/7] perf hists: Introduce hist_period_print functions Namhyung Kim
2012-08-06  8:57 ` [PATCH 4/7] perf hists: Handle field separator properly Namhyung Kim
2012-08-06  8:57 ` [PATCH 5/7] perf hists: Use hpp_functions->width to calculate the column widths Namhyung Kim
2012-08-06  8:57 ` [PATCH 6/7] perf ui/browser: Use hist_period_print functions Namhyung Kim
2012-08-06  8:57 ` [PATCH 7/7] perf gtk/browser: " Namhyung Kim
2012-08-15 10:48   ` Pekka Enberg
  -- strict thread matches above, loose matches on Subject: below --
2012-08-20  4:52 [PATCHSET 0/7] Cleanup hist printing code (v3) Namhyung Kim
2012-08-20  4:52 ` [PATCH 1/7] perf hists: Separate out hist print functions Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fw7vwijm.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox