From: Namhyung Kim <namhyung@kernel.org>
To: Jovi Zhang <bookjovi@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
mingo@redhat.com, Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf: fix wrong hw_breakpoint documentation
Date: Wed, 27 Jun 2012 17:59:34 +0900 [thread overview]
Message-ID: <87fw9hyvt5.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <CACV3sbKFcHgai6AzKGrf=LEb67VjZXjMUqMQuXAOUmby7CeiJg@mail.gmail.com> (Jovi Zhang's message of "Wed, 27 Jun 2012 16:39:19 +0800")
Hi, Jovi
On Wed, 27 Jun 2012 16:39:19 +0800, Jovi Zhang wrote:
> From f5f9c3a064482cf3d0fb7ed788c66630bddbfc79 Mon Sep 17 00:00:00 2001
> From: Jovi Zhang <bookjovi@gmail.com>
> Date: Wed, 27 Jun 2012 16:09:21 +0800
> Subject: [PATCH] perf: fix wrong hw_breakpoint documentation
>
> read-write access hw_breakpoint event is passed as 'mem:addr',
> 'mem:0x1000:rw' is parsed as invalid argument currently.
>
It should be a bug in event parser. I guess the patch below will fix it:
diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
index 488362e14133..aafca33a8a09 100644
--- a/tools/perf/util/parse-events.l
+++ b/tools/perf/util/parse-events.l
@@ -76,7 +76,7 @@ num_hex 0x[a-fA-F0-9]+
num_raw_hex [a-fA-F0-9]+
name [a-zA-Z_*?][a-zA-Z0-9_*?]*
modifier_event [ukhpGH]{1,8}
-modifier_bp [rwx]
+modifier_bp [rwx]+
%%
next prev parent reply other threads:[~2012-06-27 9:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 8:39 [PATCH] perf: fix wrong hw_breakpoint documentation Jovi Zhang
2012-06-27 8:59 ` Namhyung Kim [this message]
2012-06-27 13:40 ` Jovi Zhang
2012-06-27 16:15 ` Arnaldo Carvalho de Melo
2012-06-27 19:07 ` Jiri Olsa
2012-06-27 19:58 ` Peter Zijlstra
2012-06-27 20:19 ` Jiri Olsa
2012-06-28 1:30 ` Namhyung Kim
2012-06-28 10:32 ` Jiri Olsa
2012-06-28 21:18 ` [PATCH 0/2] perf, tool: Hw breakpoint events parsing fixes Jiri Olsa
2012-06-28 21:18 ` [PATCH 1/2] perf, tool: Fix hw breakpoint's type modifier parsing Jiri Olsa
2012-06-29 0:40 ` Namhyung Kim
2012-06-29 1:01 ` Jovi Zhang
2012-06-29 1:34 ` Namhyung Kim
2012-06-29 7:22 ` [PATCHv2 " Jiri Olsa
2012-07-06 10:57 ` [tip:perf/core] perf tools: Fix hw breakpoint' s " tip-bot for Jiri Olsa
2012-06-28 21:18 ` [PATCH 2/2] perf, tool: Handle hw breakpoints event names via perf_evsel__name Jiri Olsa
2012-07-06 10:58 ` [tip:perf/core] perf evsel: Handle hw breakpoints event names in perf_evsel__name() tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fw9hyvt5.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=bookjovi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox