From: Andi Kleen <andi@firstfloor.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Marcin Slusarz <marcin.slusarz@gmail.com>,
Stephen Hemminger <shemminger@vyatta.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 00/24] drivers/block/floppy.c cleanups
Date: Fri, 22 Jan 2010 11:47:53 +0100 [thread overview]
Message-ID: <87fx5yh0va.fsf@basil.nowhere.org> (raw)
In-Reply-To: <cover.1264133863.git.joe@perches.com> (Joe Perches's message of "Thu, 21 Jan 2010 20:52:30 -0800")
Joe Perches <joe@perches.com> writes:
> Since Stephen Hemminger is a bit too busy to do much with this
> I've broken up the first large patch into multiple pieces and
> brought the rest up to current.
Philosophically I'm not sure it's that great an idea to make bad code
look better without actually fixing/rewriting it. It's like putting
lipstick on a pig.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-01-22 10:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 4:52 [PATCH 00/24] drivers/block/floppy.c cleanups Joe Perches
2010-01-22 4:52 ` [PATCH 01/24] drivers/block/floppy.c: Convert some #include <asm/ to #include <linux/ Joe Perches
2010-01-22 4:52 ` [PATCH 02/24] drivers/block/floppy.c: #define space and column neatening Joe Perches
2010-01-22 4:52 ` [PATCH 03/24] drivers/block/floppy.c: Use pr_<level> Joe Perches
2010-01-22 4:52 ` [PATCH 04/24] drivers/block/floppy.c: Remove unnecessary braces Joe Perches
2010-01-22 4:52 ` [PATCH 05/24] drivers/block/floppy.c: Remove used once CHECK_READY macro Joe Perches
2010-01-22 4:52 ` [PATCH 06/24] drivers/block/floppy.c: Hoist assigns from if()s, neatening Joe Perches
2010-01-22 4:52 ` [PATCH 07/24] drivers/block/floppy.c: Remove LAST_OUT macro Joe Perches
2010-01-22 4:52 ` [PATCH 08/24] drivers/block/floppy.c: Comment neatening and remove naked ; Joe Perches
2010-01-22 4:52 ` [PATCH 09/24] drivers/block/floppy.c: Remove CLEARSTRUCT macro, use memset Joe Perches
2010-01-22 4:52 ` [PATCH 10/24] drivers/block/floppy.c: Indent a comment Joe Perches
2010-01-22 4:52 ` [PATCH 11/24] drivers/block/floppy.c: Remove IN/OUT macros, indent switch/case Joe Perches
2010-01-22 4:52 ` [PATCH 12/24] drivers/block/floppy.c: Remove a few spaces from function casts Joe Perches
2010-01-22 4:52 ` [PATCH 13/24] drivers/block/floppy.c: Remove macro LOCK_FDC Joe Perches
2010-01-22 4:52 ` [PATCH 14/24] drivers/block/floppy.c: Add debug_dcl(...) macro Joe Perches
2010-01-22 4:52 ` [PATCH 15/24] drivers/block/floppy.c: Remove [U]CLEARF, [U]SETF, and [U]TESTF macros Joe Perches
2010-01-22 4:52 ` [PATCH 16/24] drivers/block/floppy.c: Remove most uses of CALL and ECALL macros Joe Perches
2010-01-22 4:52 ` [PATCH 17/24] drivers/block/floppy.c: remove [_]COPYIN [_]COPYOUT " Joe Perches
2010-01-22 4:52 ` [PATCH 18/24] drivers/block/floppy.c: remove macros CALL, WAIT and IWAIT Joe Perches
2010-01-22 4:52 ` [PATCH 19/24] drivers/block/floppy.c: convert int 1/0 to bool true/false Joe Perches
2010-01-22 4:52 ` [PATCH 20/24] drivers/block/floppy.c: Move leading && and || to preceding line Joe Perches
2010-01-22 4:52 ` [PATCH 21/24] drivers/block/floppy.c: remove #define DEVICE_NAME "floppy" Joe Perches
2010-01-22 4:52 ` [PATCH 22/24] drivers/block/floppy.c: Convert int initialising to bool initialized Joe Perches
2010-01-22 4:52 ` [PATCH 23/24] drivers/block/floppy.c: Add function is_ready_state Joe Perches
2010-01-22 4:52 ` [PATCH 24/24] drivers/block/floppy.c: Remove unnecessary return and braces Joe Perches
2010-01-22 10:47 ` Andi Kleen [this message]
2010-01-22 11:46 ` [PATCH 00/24] drivers/block/floppy.c cleanups Alan Cox
2010-01-22 17:04 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fx5yh0va.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox