Re: [PATCH -mm 11/14] bootmem: respect goal more likely

Yasunori Goto
2008-06-05T02:59:56Z

Hi.

> > I'd like to straggle more, but may be need more time,
> > because, IA64 doesn't have early_printk, and console is not enable
> > at here.....
>
> Hm, just to make sure: this is the patch that breaks booting, right? If
> you apply all patches in the series before this one, the machine boots
> fine?

Yes.

>
> Could you boot a working image with bootmem_debug in the command line?
> Perhaps seeing the usual bootmem usage on this box gives a hint what is
> broken.

Ok. I'll try it.

> > P.S.
> > I was very confused by local variable namimng in alloc_bootmem_core.
> > I suppose start, max, and end, should be named like
> > sidx, eidx, and midx. They are not pfn, but index of bitmap.
>
> Okay, I will make them more clear.

Thanks.

> > However, new_start and new_end should be named as new_start_offset and
> > new_end_offset. They are not index, but offset from start address of
> > the node.
>
> Yes, that too. I would also rename last_offset to last_eidx and
> last_success to last_sidx. What do you think?

Last_sidx is ok. But, last_offset seems to be used to manage some
allocated smaller chunks than one page. I'm not sure last_eidx is ok.

Bye.

--
Yasunori Goto