From: Kevin Hilman <kevin@hilman.org>
To: linux-rt-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH/RFC -rt] local_bh_enable() is safe for irqs_disabled()
Date: Fri, 07 Dec 2007 17:41:24 -0800 [thread overview]
Message-ID: <87fxyearp7.fsf@vence.hilman.org> (raw)
In local_bh_enable() there is a WARN_ON(irqs_disabled()), but looking
at the rest of the code, it seems it expects to be used with
interrupts off, so is this warning really necessary?
I hit this warning in the ads7846 touchscreen driver timer function
where enable_irq() may be called with interrupts disabled. Since
enable_irq now calls local_bh_disable/enable for IRQ resend, this
warning is triggered.
Patch against 2.6.23.9-rt12
Signed-off-by: Kevin Hilman <khilman@mvista.com>
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 4c19017..68149ae 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -207,7 +207,6 @@ void local_bh_enable(void)
WARN_ON_ONCE(in_irq());
#endif
- WARN_ON_ONCE(irqs_disabled());
#ifdef CONFIG_TRACE_IRQFLAGS
local_irq_save(flags);
reply other threads:[~2007-12-08 1:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxyearp7.fsf@vence.hilman.org \
--to=kevin@hilman.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox