From: Yoann Padioleau <padator@wanadoo.fr>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Yoann Padioleau <padator@wanadoo.fr>,
kernel-janitors@vger.kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dev->priv to netdev_priv(dev), drivers/net/tokenring/
Date: Mon, 23 Jul 2007 17:38:39 +0200 [thread overview]
Message-ID: <87fy3fjfk0.fsf@wanadoo.fr> (raw)
In-Reply-To: <Pine.LNX.4.64.0707231712120.32367@fbirervta.pbzchgretzou.qr> (Jan Engelhardt's message of "Mon, 23 Jul 2007 17:13:07 +0200 (CEST)")
Jan Engelhardt <jengelh@computergmbh.de> writes:
> On Jul 23 2007 15:18, Yoann Padioleau wrote:
>>
>>Here is an excerpt of the semantic patch that performs the transformation
>>
>>@@
>>
>>- (T*) dev->priv
>>+ netdev_priv(dev)
>
> Note that dev->priv is a void*, and hence does not need casting.
> So dev->priv may also appear without one.
Yes you are right. I have shown only an excerpt of the semantic patch.
Sorry. There is another rule:
@ rule3 depends on rule1 && !rule1bis @
struct net_device *dev;
@@
- dev->priv
+ netdev_priv(dev)
If you look at my patch there is one such case
- struct tok_info *ti = dev->priv;
+ struct tok_info *ti = netdev_priv(dev);
next prev parent reply other threads:[~2007-07-23 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 13:18 [PATCH] dev->priv to netdev_priv(dev), drivers/net/tokenring/ Yoann Padioleau
2007-07-23 15:13 ` Jan Engelhardt
2007-07-23 15:38 ` Yoann Padioleau [this message]
2007-07-30 20:03 ` Jeff Garzik
2007-08-03 18:03 ` dev->priv to netdev_priv(dev) Yoann Padioleau
2007-08-03 23:42 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fy3fjfk0.fsf@wanadoo.fr \
--to=padator@wanadoo.fr \
--cc=akpm@linux-foundation.org \
--cc=jengelh@computergmbh.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox