public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Weimer <fw@deneb.enyo.de>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] AMD64: fix mce_cpu_quirks typos
Date: Wed, 01 Feb 2006 20:14:56 +0100	[thread overview]
Message-ID: <87fyn2yjpr.fsf@mid.deneb.enyo.de> (raw)

The spurious MCE is TLB-related.  I *think* the bit for the correct
status code is stored at position 10 HEX, not 10 DEC.  At least I
still get those MCEs on a two-way Opteron box, even though they are
supposed to be filtered out.

Signed-off-by: Florian Weimer <fw@deneb.enyo.de>

---

 arch/x86_64/kernel/mce.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

102dfead12550ecaf7363a8ca7269ac0f1241bac
diff --git a/arch/x86_64/kernel/mce.c b/arch/x86_64/kernel/mce.c
index 13a2ead..975d128 100644
--- a/arch/x86_64/kernel/mce.c
+++ b/arch/x86_64/kernel/mce.c
@@ -350,9 +350,9 @@ static void __cpuinit mce_cpu_quirks(str
 { 
 	/* This should be disabled by the BIOS, but isn't always */
 	if (c->x86_vendor == X86_VENDOR_AMD && c->x86 == 15) {
-		/* disable GART TBL walk error reporting, which trips off 
+		/* disable GART TLB walk error reporting, which trips off
 		   incorrectly with the IOMMU & 3ware & Cerberus. */
-		clear_bit(10, &bank[4]);
+		clear_bit(0x10, &bank[4]);
 		/* Lots of broken BIOS around that don't clear them
 		   by default and leave crap in there. Don't log. */
 		mce_bootlog = 0;
-- 
1.1.5

             reply	other threads:[~2006-02-01 19:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-01 19:14 Florian Weimer [this message]
2006-02-01 19:44 ` [PATCH] AMD64: fix mce_cpu_quirks typos Dave Jones
2006-02-01 19:49   ` Florian Weimer
     [not found] <87fyn2yjpr.fsf@mid.deneb.enyo.de.suse.lists.linux.kernel>
2006-02-01 19:59 ` Andi Kleen
2006-02-01 20:21   ` Florian Weimer
2006-02-01 20:43     ` Andi Kleen
2006-02-02 12:59       ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fyn2yjpr.fsf@mid.deneb.enyo.de \
    --to=fw@deneb.enyo.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox