From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB79D385D74 for ; Thu, 2 Jul 2026 22:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783030103; cv=none; b=SxANlaKguBfAng0ezfryJTFE5njp9AYLmqZz5OfSEdpRoiHQ/SSt6fggJd05N5Mss9++En7v5uP6qgCpNc9rSkHetveKDZFC8AfJVOnztWalxfmJGh3HvEc3aBKcsY4ybQYJagL9USpTLJAnm1mPQqxmm6hjscSJiIzU5fL8NqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783030103; c=relaxed/simple; bh=9nDgxadY+rcW43cUmKBpg7vWz8YPD7hkWR/yrDoRuq0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=csGC6KQ/gplKbK0S1H/dEYY7ZPsPFPC9TZWDmhklOVXOdwVx6VKMI/GVu7N39EWl+xZV6BSZuztj4m05QmeDu7fGjHteIzHUym0P3UMOWSLYU617XdrZbRz+PwYa63zP2ke8hVryyZBmUUJiVbJYecK2pibqcvn/oEeq2RP6yL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kfGWxluK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kfGWxluK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E5C91F000E9; Thu, 2 Jul 2026 22:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783030102; bh=Yzi8WBu4KujBYoF2CzJN07cCvMBEcE/HJeNevlQaE4I=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=kfGWxluKtGo8vdz42fwQgulPVuMznMV1PWOTLBGUXYfKic36EXdVZLLP1g6uOSoRG PV3vQpEZfWfQFLEB88U8rGIXhBjW9jmHh5/Vrf4SqHnXt5840RpqjhY4xuLG/tZ+g9 /6RP8aB+ZimPbkXslfAVXhsNC/c58w0EsNWchQrODwqvpv1h6jkWVGUb6JJ6P1eU2j zFi5n6GRhUpiyi84oSiNOPP32fK//Ly+myohXHQxULXp2LEkKHm83eIHYW9yKOMjnx TCdf8vDkX97DpYZIZAxMctYPiFNoRPif00juP6RHLLt3eD1+zs8IGSNKYLOT1lxK0i clWZCZ1WxSKOQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wfPa0-00000000vYv-2cTc; Thu, 02 Jul 2026 22:08:20 +0000 Date: Thu, 02 Jul 2026 23:10:09 +0100 Message-ID: <87h5mh6o1q.wl-maz@kernel.org> From: Marc Zyngier To: Kemeng Shi Cc: tglx@kernel.org, lpieralisi@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/6] irqchip/gic-v3-its: Add ITS address info in more error logs In-Reply-To: <20260702033050.1583-5-shikemeng@huaweicloud.com> References: <20260702033050.1583-1-shikemeng@huaweicloud.com> <20260702033050.1583-5-shikemeng@huaweicloud.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: shikemeng@huaweicloud.com, tglx@kernel.org, lpieralisi@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 02 Jul 2026 04:30:48 +0100, Kemeng Shi wrote: > > Multiple ITS units may exist in a system. When an error occurs, it is > difficult to identify which ITS triggered it because most error logs > lack the ITS address. Some logs already include this information and > is useful for debugging. Add the ITS address to the remaining error > logs so that all ITS-related errors can be consistently attributed to > a specific ITS instance. I already said *no* to this. If you want to log errors, implement a PMU or RAS driver that reports errors on a per ITS basis, in a way that is collectable by existing tooling. The kernel log is not the place for your sorry debug hacks, which is in general not readable by normal users. And I'd rather remove the other instances as a matter of consistency. M. -- Jazz isn't dead. It just smells funny.