From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81F223542F4 for ; Fri, 17 Apr 2026 07:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776412643; cv=none; b=duLmWbuh9OZgZVEncKXPpSCH9wSWqS7r9gjIm0O2Gj+1CzVNuj0LQlLoLdfT0eYGFFsH/6GmC8JtNGg75jds0I+f1z1mwvpDMxsai96xPdmCZuGU1x44c+Z1djlqXjO3AkXhKqEFNiPs3b0m8Kknr4XhGFB2eN4viJcAMterd2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776412643; c=relaxed/simple; bh=h7V5gRHeUyFMvCWkEJCqp9jf9FaT/CFPhsUjrAEDjFg=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=EhmgBd4GxVJ9i7d2bCgveSoyn9euljX3a6p8I8VSfewCONNWWKH6roU/sywzscAhGPcJ47Kzc2J7/jDMCFJ67FSaH2zzaiWnxMku//kZiNFFra9dmdZ3rQrQzQDnM3EuvPDpHq6Jm9UbS1LoxF/CUFOuoo4ZoeNxdu4OSSDTZt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=uOtKqEKg; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ElttCxlc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=uOtKqEKg; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ElttCxlc; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="uOtKqEKg"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ElttCxlc"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="uOtKqEKg"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ElttCxlc" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E5E336A98D; Fri, 17 Apr 2026 07:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776412640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dONKJJqrYHVWrPyzvTCLEzVqE1Rbhu06dwqhlHYiL74=; b=uOtKqEKgmKfdm/E42q706GhWNJy5Eemhi6eg5BlCNzasST7j7Vq85NxVx+OA2bI3ZbCrPX t/azF/GBqvGCaIIMefWCGMWWxm3BYX56x4f8HdU0ie96XlyhRiw4lKqpcXuqKFs5GEhXg1 lSaVvay+MIaBS5xSw0hCVYOiQe07bh8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776412640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dONKJJqrYHVWrPyzvTCLEzVqE1Rbhu06dwqhlHYiL74=; b=ElttCxlc88ZyxCbjdtiuIbeUGOMD609JQ6QNA3aHae1fd69ZBrCFvWM6dPMqOfqmgO/0Dz ZISwa/xBaIZtRQDQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uOtKqEKg; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ElttCxlc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776412640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dONKJJqrYHVWrPyzvTCLEzVqE1Rbhu06dwqhlHYiL74=; b=uOtKqEKgmKfdm/E42q706GhWNJy5Eemhi6eg5BlCNzasST7j7Vq85NxVx+OA2bI3ZbCrPX t/azF/GBqvGCaIIMefWCGMWWxm3BYX56x4f8HdU0ie96XlyhRiw4lKqpcXuqKFs5GEhXg1 lSaVvay+MIaBS5xSw0hCVYOiQe07bh8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776412640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dONKJJqrYHVWrPyzvTCLEzVqE1Rbhu06dwqhlHYiL74=; b=ElttCxlc88ZyxCbjdtiuIbeUGOMD609JQ6QNA3aHae1fd69ZBrCFvWM6dPMqOfqmgO/0Dz ZISwa/xBaIZtRQDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B00DE593AE; Fri, 17 Apr 2026 07:57:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id W8qbKeDn4WkeHgAAD6G6ig (envelope-from ); Fri, 17 Apr 2026 07:57:20 +0000 Date: Fri, 17 Apr 2026 09:57:20 +0200 Message-ID: <87h5padnof.wl-tiwai@suse.de> From: Takashi Iwai To: Guangshuo Li Cc: Ivan Orlov , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ALSA: pcmtest: fix reference leak on failed device registration In-Reply-To: <20260415193138.3861297-1-lgs201920130244@gmail.com> References: <20260415193138.3861297-1-lgs201920130244@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-2.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[gmail.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FREEMAIL_CC(0.00)[gmail.com,perex.cz,suse.com,vger.kernel.org]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_SEVEN(0.00)[7]; TAGGED_RCPT(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid] X-Rspamd-Queue-Id: E5E336A98D X-Spam-Flag: NO X-Spam-Score: -2.01 X-Spam-Level: On Wed, 15 Apr 2026 21:31:38 +0200, Guangshuo Li wrote: > > When platform_device_register() fails in mod_init(), the embedded struct > device in pcmtst_pdev has already been initialized by > device_initialize(), but the failure path returns the error without > dropping the device reference for the current platform device: > > mod_init() > -> platform_device_register(&pcmtst_pdev) > -> device_initialize(&pcmtst_pdev.dev) > -> setup_pdev_dma_masks(&pcmtst_pdev) > -> platform_device_add(&pcmtst_pdev) > > This leads to a reference leak when platform_device_register() fails. > Fix this by calling platform_device_put() before returning the error. > > The issue was identified by a static analysis tool I developed and > confirmed by manual review. > > Fixes: 315a3d57c64c5 ("ALSA: Implement the new Virtual PCM Test Driver") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li Thanks, applied now. Takashi