[PATCH 0/3] Fix spear600-smi YAML conversion

[PATCH 0/3] Fix spear600-smi YAML conversion

[Miquel Raynal]

Recent conversion from txt to yaml of the Spear600 SMI binding by Akhila
lead to warnings. These are my 2cts in getting the yaml conversion done
:-)

Cheers,
Miquèl

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
Miquel Raynal (3):
      dt-bindings: mtd: st,spear600-smi: Fix description
      dt-bindings: mtd: st,spear600-smi: #address/size-cells is mandatory
      dt-bindings: mtd: st,spear600-smi: Fix example

 .../devicetree/bindings/mtd/st,spear600-smi.yaml   | 26 ++++++++++++++++------
 1 file changed, 19 insertions(+), 7 deletions(-)
---
base-commit: 7dff99b354601dd01829e1511711846e04340a69
change-id: 20260225-perso-fix-spear600-smi-yaml-801918ea96b9

Best regards,
-- 
Miquel Raynal <miquel.raynal@bootlin.com>

[PATCH 1/3] dt-bindings: mtd: st,spear600-smi: Fix description

[Miquel Raynal]

The description mixes two nodes. There is the controller, and there is
the flash. Describe the flash (which itself can be considered an mtd
device, unlike the top level controller), and move the st,smi-fast-mode
property inside, as this property is flash specific and should not live
in the parent controller node.

Fixes: 68cd8ef48452 ("dt-bindings: mtd: st,spear600-smi: convert to DT schema")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 .../devicetree/bindings/mtd/st,spear600-smi.yaml   | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml b/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
index 8fe27aae7527..d065df269657 100644
--- a/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
+++ b/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
@@ -19,9 +19,6 @@ description:
   Flash sub nodes describe the memory range and optional per-flash
   properties.
 
-allOf:
-  - $ref: mtd.yaml#
-
 properties:
   compatible:
     const: st,spear600-smi
@@ -42,9 +39,22 @@ properties:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: Functional clock rate of the SMI controller in Hz.
 
-  st,smi-fast-mode:
-    type: boolean
-    description: Indicates that the attached flash supports fast read mode.
+patternProperties:
+  "^flash@.*$":
+    $ref: /schemas/mtd/mtd.yaml#
+
+    properties:
+      reg:
+        maxItems: 1
+
+      st,smi-fast-mode:
+        type: boolean
+        description: Indicates that the attached flash supports fast read mode.
+
+    unevaluatedProperties: false
+
+    required:
+      - reg
 
 required:
   - compatible

-- 
2.51.1

Re: [PATCH 1/3] dt-bindings: mtd: st,spear600-smi: Fix description

[Rob Herring (Arm)]

On Wed, 25 Feb 2026 17:24:43 +0100, Miquel Raynal wrote:
> The description mixes two nodes. There is the controller, and there is
> the flash. Describe the flash (which itself can be considered an mtd
> device, unlike the top level controller), and move the st,smi-fast-mode
> property inside, as this property is flash specific and should not live
> in the parent controller node.
> 
> Fixes: 68cd8ef48452 ("dt-bindings: mtd: st,spear600-smi: convert to DT schema")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  .../devicetree/bindings/mtd/st,spear600-smi.yaml   | 22 ++++++++++++++++------
>  1 file changed, 16 insertions(+), 6 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH 2/3] dt-bindings: mtd: st,spear600-smi: #address/size-cells is mandatory

[Miquel Raynal]

These properties must be set because they overwrite the default values,
especially #size-cells which is 0 for most controllers and is 'const: 1'
here.

Fixes: 68cd8ef48452 ("dt-bindings: mtd: st,spear600-smi: convert to DT schema")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml b/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
index d065df269657..62d4359908f2 100644
--- a/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
+++ b/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
@@ -60,6 +60,8 @@ required:
   - compatible
   - reg
   - clock-rate
+  - "#address-cells"
+  - "#size-cells"
 
 unevaluatedProperties: false
 

-- 
2.51.1

Re: [PATCH 2/3] dt-bindings: mtd: st,spear600-smi: #address/size-cells is mandatory

[Rob Herring (Arm)]

On Wed, 25 Feb 2026 17:24:44 +0100, Miquel Raynal wrote:
> These properties must be set because they overwrite the default values,
> especially #size-cells which is 0 for most controllers and is 'const: 1'
> here.
> 
> Fixes: 68cd8ef48452 ("dt-bindings: mtd: st,spear600-smi: convert to DT schema")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH 3/3] dt-bindings: mtd: st,spear600-smi: Fix example

[Miquel Raynal]

Example is wrong, the reg property of the flash is always matching the
node name.

Fixes: 68cd8ef48452 ("dt-bindings: mtd: st,spear600-smi: convert to DT schema")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml b/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
index 62d4359908f2..e7385d906591 100644
--- a/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
+++ b/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
@@ -76,7 +76,7 @@ examples:
         interrupts = <12>;
         clock-rate = <50000000>;  /* 50 MHz */
 
-        flash@f8000000 {
+        flash@fc000000 {
             reg = <0xfc000000 0x1000>;
             st,smi-fast-mode;
         };

-- 
2.51.1

Re: [PATCH 3/3] dt-bindings: mtd: st,spear600-smi: Fix example

[Rob Herring (Arm)]

On Wed, 25 Feb 2026 17:24:45 +0100, Miquel Raynal wrote:
> Example is wrong, the reg property of the flash is always matching the
> node name.
> 
> Fixes: 68cd8ef48452 ("dt-bindings: mtd: st,spear600-smi: convert to DT schema")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 0/3] Fix spear600-smi YAML conversion

[Rob Herring]

On Wed, Feb 25, 2026 at 10:24 AM Miquel Raynal
<miquel.raynal@bootlin.com> wrote:
>
> Recent conversion from txt to yaml of the Spear600 SMI binding by Akhila
> lead to warnings. These are my 2cts in getting the yaml conversion done
> :-)
>
> Cheers,
> Miquèl
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> Miquel Raynal (3):
>       dt-bindings: mtd: st,spear600-smi: Fix description
>       dt-bindings: mtd: st,spear600-smi: #address/size-cells is mandatory
>       dt-bindings: mtd: st,spear600-smi: Fix example
>
>  .../devicetree/bindings/mtd/st,spear600-smi.yaml   | 26 ++++++++++++++++------
>  1 file changed, 19 insertions(+), 7 deletions(-)

Still warning in next and v7.0-rc without these fixes. Please apply them soon.

Rob

Re: [PATCH 0/3] Fix spear600-smi YAML conversion

[Miquel Raynal]

Hi Rob,

On 10/03/2026 at 13:30:02 -05, Rob Herring <robh@kernel.org> wrote:

> On Wed, Feb 25, 2026 at 10:24 AM Miquel Raynal
> <miquel.raynal@bootlin.com> wrote:
>>
>> Recent conversion from txt to yaml of the Spear600 SMI binding by Akhila
>> lead to warnings. These are my 2cts in getting the yaml conversion done
>> :-)
>>
>> Cheers,
>> Miquèl
>>
>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> ---
>> Miquel Raynal (3):
>>       dt-bindings: mtd: st,spear600-smi: Fix description
>>       dt-bindings: mtd: st,spear600-smi: #address/size-cells is mandatory
>>       dt-bindings: mtd: st,spear600-smi: Fix example
>>
>>  .../devicetree/bindings/mtd/st,spear600-smi.yaml   | 26 ++++++++++++++++------
>>  1 file changed, 19 insertions(+), 7 deletions(-)
>
> Still warning in next and v7.0-rc without these fixes. Please apply
> them soon.

Yes, I will do it this week.

Thanks for the reminder,
Miquèl

Re: [PATCH 0/3] Fix spear600-smi YAML conversion

[Miquel Raynal]

On Wed, 25 Feb 2026 17:24:42 +0100, Miquel Raynal wrote:
> Recent conversion from txt to yaml of the Spear600 SMI binding by Akhila
> lead to warnings. These are my 2cts in getting the yaml conversion done
> :-)
> 
> Cheers,
> Miquèl
> 
> [...]

Applied to mtd/next, thanks!

[1/3] dt-bindings: mtd: st,spear600-smi: Fix description
      commit: f9b2ac395d91fa974c0922bc949bbb6c8db58f3e
[2/3] dt-bindings: mtd: st,spear600-smi: #address/size-cells is mandatory
      commit: 88527c84fffe51a912f36eaf1b0ef11acbcff5e7
[3/3] dt-bindings: mtd: st,spear600-smi: Fix example
      commit: 0bfed8aaf864ec42a84bd68092923282d764136b

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl

Re: [PATCH 0/3] Fix spear600-smi YAML conversion

[Miquel Raynal]

On 11/03/2026 at 16:25:48 +01, Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> On Wed, 25 Feb 2026 17:24:42 +0100, Miquel Raynal wrote:
>> Recent conversion from txt to yaml of the Spear600 SMI binding by Akhila
>> lead to warnings. These are my 2cts in getting the yaml conversion done
>> :-)
>> 
>> Cheers,
>> Miquèl
>> 
>> [...]
>
> Applied to mtd/next, thanks!

I moved them to mtd/fixes, they will be queued in the next MTD fixes PR.