From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C790834403E for ; Mon, 9 Mar 2026 08:56:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773046569; cv=none; b=mGqzW4MQkGw8QnUHBaMkID7/pLnydPVB4eVRqMqm5XMmMqKq+6bCPtbEvCdqzUgbL5iGEyKIZM1qxxTGHc9FSFYPAs/R2t5sNOUtJ1FA7MTlxcWU7IcD/Shrar3lA54XquIb9ikEJgh5eWDfMHt96cMEQcOU2fX/BV+iCkQm+8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773046569; c=relaxed/simple; bh=11tlPpTwnFTyOQw1wgwUs3kQCRJtAAlwuHiVJT4IYFY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=IoXuxNvyQfdoTM1ky/79CJtRMPkUeS9f8860HFLWmWbEQa8mpu5ACpZM/KVsmOBCIL6u/zktJtxAQAh95UILu8epPCPh5xF926pZ9rP/advtO+lcmd6tSF//zbG/70DK96reLAtHzLcEQ0yWQgjioNq3VTIaFXSH4mK18fNAMvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=XbDj2xhy; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="XbDj2xhy" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 20312C42871; Mon, 9 Mar 2026 08:56:23 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B05405FFB8; Mon, 9 Mar 2026 08:56:02 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3EAB710369ABE; Mon, 9 Mar 2026 09:55:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773046562; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=11tlPpTwnFTyOQw1wgwUs3kQCRJtAAlwuHiVJT4IYFY=; b=XbDj2xhy9DohxFWLd7waC1Pmlf92tPz5ciU2e1nwLgwpnzjErvemmxcSPrHEka60r0Zl4Z T29OUXg5Mj5oUPNNOuTlVKC0NXdXBf7kTxUa5vnggUT77vnn2MoF1IYtprC3R0H4phjbXT xVPEiqHSDhFw7eJqYpXWYReS9wpwxGasU6r0ZwFy8hjdPpEzU5yKxbjPQxGpv+015Szo5A /0FE83ZUlKsm6pOS/hWSCA2Hxxm6/BTw97BSwuG31Z9iC1im0chItp6D/JWy6Mf80+lDCt 1hdSPMZa7+Lnf2BB2Kpyd5rE+NTjrloHl1NMIU2keGrAx3g8bAMT+3EqQPUMJg== From: Miquel Raynal To: Johan Hovold Cc: Stefan Schmidt , Alexander Aring , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ieee802154: atusb: drop redundant device reference In-Reply-To: <20260305104313.15898-1-johan@kernel.org> (Johan Hovold's message of "Thu, 5 Mar 2026 11:43:13 +0100") References: <20260305104313.15898-1-johan@kernel.org> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 09 Mar 2026 09:55:57 +0100 Message-ID: <87h5qpgz4y.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 05/03/2026 at 11:43:13 +01, Johan Hovold wrote: > Driver core holds a reference to the USB interface and its parent USB > device while the interface is bound to a driver and there is no need to > take additional references unless the structures are needed after > disconnect. > > Drop the redundant device reference to reduce cargo culting, make it > easier to spot drivers where an extra reference is needed, and reduce > the risk of memory leaks when drivers fail to release it. > > Signed-off-by: Johan Hovold I'm not qualified enough to judge how useful that can be, but on the other hand I don't believe it will hurt either, so: Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l