public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Marco Crivellari <marco.crivellari@suse.com>,
	Waiman Long <llong@redhat.com>,
	cgroups@vger.kernel.org
Subject: Re: [PATCH 1/2] genirq: Fix IRQ threads affinity VS cpuset isolated partitions
Date: Thu, 20 Nov 2025 20:09:00 +0100	[thread overview]
Message-ID: <87h5uojzcj.ffs@tglx> (raw)
In-Reply-To: <aR84qyZp3PyH5xFg@localhost.localdomain>

On Thu, Nov 20 2025 at 16:50, Frederic Weisbecker wrote:
> Le Thu, Nov 20, 2025 at 04:00:39PM +0100, Thomas Gleixner a écrit :
>> +	if (!secondary)
>> +		t = kthread_create_on_cpu(irq_thread, new, cpu, "irq/%d-%s", irq, new->name);
>> +	else
>> +		t = kthread_create_on_cpu(irq_thread, new, cpu, "irq/%d-s-%s",
>> -		irq, new->name);
>
> Right I though about something like that, it involved:
>
> kthread_bind_mask(t, cpu_possible_mask);

That's way simpler and also solves the problem with the
kthread_create_on_cpu() name which Marek pointed out.

> Which do you prefer? Also do you prefer such a fixup or should I refactor my
> patches you merged?

Can you split out the wakeup change into a separate patch
(Suggested-by-me) with it's own change log and fold the
kthread_bind_mask() + set(AFFINITY) bit into this one.

I just go and zap the existing commits (they are on top of the branch).

Thanks,

        tglx

  reply	other threads:[~2025-11-20 19:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 14:30 [PATCH 0/2] genirq: Fix IRQ threads VS cpuset Frederic Weisbecker
2025-11-18 14:30 ` [PATCH 1/2] genirq: Fix IRQ threads affinity VS cpuset isolated partitions Frederic Weisbecker
2025-11-18 15:26   ` [tip: irq/core] genirq: Fix interrupt threads affinity vs. " tip-bot2 for Frederic Weisbecker
2025-11-18 16:27   ` [PATCH 1/2] genirq: Fix IRQ threads affinity VS " Waiman Long
2025-11-18 17:23     ` Thomas Gleixner
2025-11-18 17:29       ` Waiman Long
2025-11-20 11:51   ` Marek Szyprowski
2025-11-20 13:20     ` Frederic Weisbecker
2025-11-20 15:00       ` Thomas Gleixner
2025-11-20 15:50         ` Frederic Weisbecker
2025-11-20 19:09           ` Thomas Gleixner [this message]
2025-11-20 16:34         ` Marek Szyprowski
2025-11-20 13:45     ` Thomas Gleixner
2025-11-18 14:30 ` [PATCH 2/2] genirq: Remove cpumask availability check on kthread affinity setting Frederic Weisbecker
2025-11-18 15:26   ` [tip: irq/core] " tip-bot2 for Frederic Weisbecker
2025-11-18 15:14 ` [PATCH 0/2] genirq: Fix IRQ threads VS cpuset Thomas Gleixner
2025-11-18 17:44   ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h5uojzcj.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=cgroups@vger.kernel.org \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llong@redhat.com \
    --cc=m.szyprowski@samsung.com \
    --cc=marco.crivellari@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox