From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Santhosh Kumar K <s-k6@ti.com>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Steam Lin <stlin2@winbond.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 14/19] mtd: spinand: Use more specific naming for the (quad) program load op
Date: Thu, 03 Apr 2025 12:23:00 +0200 [thread overview]
Message-ID: <87h63535ob.fsf@bootlin.com> (raw)
In-Reply-To: <e1d8108f-50c1-4924-bb68-53436728e701@linaro.org> (Tudor Ambarus's message of "Thu, 3 Apr 2025 11:00:46 +0100")
On 03/04/2025 at 11:00:46 +01, Tudor Ambarus <tudor.ambarus@linaro.org> wrote:
> On 4/3/25 10:19 AM, Miquel Raynal wrote:
>> SPI operations have been initially described through macros implicitly
>> implying the use of a single SPI SDR bus. Macros for supporting dual and
>> quad I/O transfers have been added on top, generally inspired by vendor
>> naming, followed by DTR operations. Soon we might see octal
>> and even octal DTR operations as well (including the opcode byte).
>>
>> Let's clarify what the macro really means by describing the expected bus
>> topology in the (quad) program load macro name.
>>
>> While at modifying it, better add the missing_ OP suffix to align with
>> all the other macros of the same kind.
>>
>> Acked-by: Tudor Ambarus <tudor.ambarus@linaro.org>
>> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
>
> I don't remember giving R-b on this, not seeing it on ml as well, so
> please drop it when applying.
>
> I used Acked-by and not R-b because I wanted to signify that I'm OK with
> the general idea of the patches and that I'm OK with them landing, but I
> may not have reviewed it as thoroughly as if a Reviewed-by: was
> provided. Please use only the tags that I sent. And if by mistake I sent
> both A-b and R-b, use just the latter. Thanks!
I use b4 for collecting tags, but yeah that's strange.
I will use your Acked-by here.
next prev parent reply other threads:[~2025-04-03 10:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 9:19 [PATCH v2 00/19] mtd: spinand: Add octal support Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 01/19] mtd: spinand: Use more specific naming for the reset op Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 02/19] mtd: spinand: Use more specific naming for the write enable/disable op Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 03/19] mtd: spinand: Use more specific naming for the read ID op Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 04/19] mtd: spinand: Use more specific naming for the get/set feature ops Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 05/19] mtd: spinand: Use more specific naming for the erase op Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 06/19] mtd: spinand: Use more specific naming for the page read op Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 07/19] mtd: spinand: Use more specific naming for the (single) read from cache ops Miquel Raynal
2025-04-03 9:51 ` Tudor Ambarus
2025-04-03 9:19 ` [PATCH v2 08/19] mtd: spinand: Use more specific naming for the (dual output) " Miquel Raynal
2025-04-03 9:53 ` Tudor Ambarus
2025-04-03 9:19 ` [PATCH v2 09/19] mtd: spinand: Use more specific naming for the (dual IO) " Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 10/19] mtd: spinand: Use more specific naming for the (quad output) " Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 11/19] mtd: spinand: Use more specific naming for the (quad IO) " Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 12/19] mtd: spinand: Use more specific naming for the program execution op Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 13/19] mtd: spinand: Use more specific naming for the (single) program load op Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 14/19] mtd: spinand: Use more specific naming for the (quad) " Miquel Raynal
2025-04-03 10:00 ` Tudor Ambarus
2025-04-03 10:23 ` Miquel Raynal [this message]
2025-04-03 9:19 ` [PATCH v2 15/19] mtd: spinand: Define octal operations Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 16/19] mtd: spinand: winbond: Rename DTR variants Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 17/19] mtd: spinand: winbond: Add support for W35N01JW in single mode Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 18/19] mtd: spinand: winbond: Add octal support Miquel Raynal
2025-04-03 9:19 ` [PATCH v2 19/19] mtd: spinand: winbond: Add support for W35N02JW and W35N04JW chips Miquel Raynal
2025-04-03 10:13 ` Tudor Ambarus
2025-04-03 10:35 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h63535ob.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=s-k6@ti.com \
--cc=stlin2@winbond.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox