The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: jack Livingood <jacklivingood@comcast.net>
Cc: sfr@canb.auug.org.au, tiwai@suse.de,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/4] sounds: firewire: isight: changed strcpy to strscpy
Date: Wed, 12 Feb 2025 08:23:46 +0100	[thread overview]
Message-ID: <87h64zmxrx.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250212012346.83516-1-jacklivingood@comcast.net>

On Wed, 12 Feb 2025 02:23:46 +0100,
jack Livingood wrote:
> 
> From: Jack Livingood <jacklivingood@comcast.net>
> 
> fixed a spelling issue in the commit made previous

I already discarded your previous patch, so please give a full
description.


Takashi

> 
> Signed-off-by: Jack Livingood <jacklivingood@comcast.net>
> ---
>  sound/firewire/isight.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/firewire/isight.c b/sound/firewire/isight.c
> index 806f82c9ceee..e9617fc0a532 100644
> --- a/sound/firewire/isight.c
> +++ b/sound/firewire/isight.c
> @@ -637,13 +637,13 @@ static int isight_probe(struct fw_unit *unit,
>  
>  	card->private_free = isight_card_free;
>  
> -	strcpy(card->driver, "iSight");
> -	strcpy(card->shortname, "Apple iSight");
> +	strscpy(card->driver, "iSight");
> +	strscpy(card->shortname, "Apple iSight");
>  	snprintf(card->longname, sizeof(card->longname),
>  		 "Apple iSight (GUID %08x%08x) at %s, S%d",
>  		 fw_dev->config_rom[3], fw_dev->config_rom[4],
>  		 dev_name(&unit->device), 100 << fw_dev->max_speed);
> -	strcpy(card->mixername, "iSight");
> +	strscpy(card->mixername, "iSight");
>  
>  	err = isight_create_pcm(isight);
>  	if (err < 0)
> -- 
> 2.48.1
> 

      reply	other threads:[~2025-02-12  7:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12  1:23 [PATCH 1/4] sounds: firewire: isight: changed strcpy to strscpy jack Livingood
2025-02-12  7:23 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h64zmxrx.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=jacklivingood@comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox