From: Thomas Gleixner <tglx@linutronix.de>
To: "Marek Maślanka" <mmaslanka@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Rajneesh Bhardwaj" <irenic.rajneesh@gmail.com>,
"David E Box" <david.e.box@intel.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Stultz" <jstultz@google.com>,
"Stephen Boyd" <sboyd@kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3] platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended
Date: Wed, 31 Jul 2024 18:33:30 +0200 [thread overview]
Message-ID: <87h6c55xnp.ffs@tglx> (raw)
In-Reply-To: <CAGcaFA1HJBYacvDAkZAO9HNhT2dZO7OdgcBYb59p7OJkVqQ6Fw@mail.gmail.com>
Marek!
On Wed, Jul 31 2024 at 16:44, Marek Maślanka wrote:
> On Tue, Jul 30, 2024 at 6:08 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>> On Tue, Jul 30 2024 at 12:05, Marek Maslanka wrote:
>> +static void acpi_pm_disable(struct clocksource *cs)
>> +{
>> + acpi_pm_enabled = false;
>> + if (enable_callback)
>> + enable_callback(false);
>> +}
>> +
>> static struct clocksource clocksource_acpi_pm = {
>> .name = "acpi_pm",
>> .rating = 200,
>> .read = acpi_pm_read,
>> .mask = (u64)ACPI_PM_MASK,
>> .flags = CLOCK_SOURCE_IS_CONTINUOUS,
>> + .enable = acpi_pm_enable,
>> + .disable = acpi_pm_disable,
>> };
>>
> Thanks. I'll try do this in that way. But I need to disable/enable
> ACPI PM timer only on suspend/resume, so I'll use suspend/resume
> callbacks.
Why? What's the point of keeping it running when nothing uses it?
Thanks,
tglx
next prev parent reply other threads:[~2024-07-31 16:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 22:25 [PATCH] platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended Marek Maslanka
2024-07-02 8:02 ` Hans de Goede
2024-07-02 22:41 ` Marek Maślanka
2024-07-03 11:38 ` [PATCH v2] " Marek Maslanka
2024-07-03 16:30 ` Rajneesh Bhardwaj
2024-07-11 15:34 ` David E. Box
2024-07-15 12:39 ` Marek Maślanka
2024-07-30 12:05 ` [PATCH v3] " Marek Maslanka
2024-07-30 12:57 ` Ilpo Järvinen
2024-07-30 16:08 ` Thomas Gleixner
2024-07-31 14:44 ` Marek Maślanka
2024-07-31 16:33 ` Thomas Gleixner [this message]
2024-07-31 21:41 ` Marek Maślanka
2024-07-31 21:46 ` Thomas Gleixner
2024-08-06 7:24 ` Ilpo Järvinen
2024-08-09 13:13 ` [PATCH v4 1/2] clocksource: acpi_pm: Add external callback for suspend/resume Marek Maslanka
2024-08-09 13:13 ` [PATCH v4 2/2] platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended Marek Maslanka
2024-08-09 16:36 ` Thomas Gleixner
2024-08-12 4:40 ` [PATCH v5 " Marek Maslanka
2024-08-12 7:49 ` Ilpo Järvinen
2024-08-12 18:42 ` [PATCH v6 " Marek Maslanka
2024-08-19 11:31 ` Hans de Goede
2024-09-06 18:56 ` [tip: timers/core] " tip-bot2 for Marek Maslanka
2024-08-09 19:15 ` [PATCH v4 1/2] clocksource: acpi_pm: Add external callback for suspend/resume Thomas Gleixner
2024-08-12 4:37 ` [PATCH v5 " Marek Maslanka
2024-08-12 8:03 ` Hans de Goede
2024-08-12 18:41 ` [PATCH v6 " Marek Maslanka
2024-08-19 11:31 ` Hans de Goede
2024-08-19 11:35 ` Hans de Goede
2024-08-19 18:31 ` Daniel Lezcano
2024-09-06 18:56 ` [tip: timers/core] " tip-bot2 for Marek Maslanka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6c55xnp.ffs@tglx \
--to=tglx@linutronix.de \
--cc=david.e.box@intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=irenic.rajneesh@gmail.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmaslanka@google.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox