The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Andreas Hindborg (Samsung)" <nmi@metaspace.dk>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Wedson Almeida Filho" <wedsonaf@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Vincent Guittot" <vincent.guittot@linaro.org>,
	rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: rust: Clarify that 'rustup override' applies to build directory
Date: Mon, 11 Dec 2023 09:09:22 +0100	[thread overview]
Message-ID: <87h6kpf9am.fsf@metaspace.dk> (raw)
In-Reply-To: <20231211064742.63l4cmvxe4uso5us@vireshk-i7>


Thanks for fixing this Viresh!

Viresh Kumar <viresh.kumar@linaro.org> writes:

> diff --git a/Documentation/rust/quick-start.rst b/Documentation/rust/quick-start.rst
> index f382914f4191..dee787f92d26 100644
> --- a/Documentation/rust/quick-start.rst
> +++ b/Documentation/rust/quick-start.rst
> @@ -33,14 +33,17 @@ A particular version of the Rust compiler is required. Newer versions may or
>  may not work because, for the moment, the kernel depends on some unstable
>  Rust features.
>
> -If ``rustup`` is being used, enter the checked out source code directory
> -and run::
> +If ``rustup`` is being used, enter the kernel build directory and run::
>
>         rustup override set $(scripts/min-tool-version.sh rustc)

How about just specifying the path here:

         rustup override set --path=<build-dir> $(scripts/min-tool-version.sh rustc)

Best regards,
Andreas


  reply	other threads:[~2023-12-11  8:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08 10:18 [PATCH] docs: rust: Clarify that 'rustup override' applies to build directory Viresh Kumar
2023-12-08 10:32 ` Alice Ryhl
2023-12-08 15:06 ` Miguel Ojeda
2023-12-08 18:04 ` Benno Lossin
2023-12-11  6:47   ` Viresh Kumar
2023-12-11  8:09     ` Andreas Hindborg (Samsung) [this message]
2023-12-11  8:23       ` Viresh Kumar
2023-12-11 10:12         ` Benno Lossin
2023-12-12  3:05     ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6kpf9am.fsf@metaspace.dk \
    --to=nmi@metaspace.dk \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=corbet@lwn.net \
    --cc=gary@garyguo.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=wedsonaf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox