From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD666C6FD1C for ; Fri, 24 Mar 2023 15:37:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232131AbjCXPhJ (ORCPT ); Fri, 24 Mar 2023 11:37:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjCXPhG (ORCPT ); Fri, 24 Mar 2023 11:37:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97FAF212BC for ; Fri, 24 Mar 2023 08:36:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4A19AB82521 for ; Fri, 24 Mar 2023 15:36:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C145C433D2; Fri, 24 Mar 2023 15:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679672210; bh=JCroMqQZjd+JN22GhzD0TxeeMsNCRchQHQcBnwVYkSM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gY3e/mJ/BAEHGarQPwK4hywyE8CuCrzDNeEE540i+DpqezkKjOVjmMyRZexUJY6Lb vWxMcSccIzeO51DiWhBAtsYucy4FefYh+y3B34M/Nqh171V5v3N2+PbGAMweEKPu7V JFg8AJ/kcexTespW/ib1WlZh6d5tV4jyMv8jRPyqVJu+5ZOSDzkmQt+TPifXn0hcCM J4keEAw0fdrMyhFL79Zz+YlCDwtbu9vuvSzfqboDoYGxDRXO7OrS81KlOgfNYT7gp7 pVEeq4O3wNtqaRUSpajXW4dr/NpYHbIOCFLTigNejBGX4GFhlZ0RzZSWHUS5iSCEN9 hGWOileIrm66Q== Received: from [104.132.96.108] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pfjTD-002rFu-B2; Fri, 24 Mar 2023 15:36:47 +0000 Date: Fri, 24 Mar 2023 15:36:43 +0000 Message-ID: <87h6uagnzo.wl-maz@kernel.org> From: Marc Zyngier To: Jianmin Lv Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, Lorenzo Pieralisi , Jiaxun Yang , Huacai Chen , loongson-kernel@lists.loongnix.cn Subject: Re: [PATCH V1 1/5] irqchip/loongson-eiointc: Fix returned value on parsing MADT In-Reply-To: <20230324060854.29375-2-lvjianmin@loongson.cn> References: <20230324060854.29375-1-lvjianmin@loongson.cn> <20230324060854.29375-2-lvjianmin@loongson.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 104.132.96.108 X-SA-Exim-Rcpt-To: lvjianmin@loongson.cn, tglx@linutronix.de, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, lorenzo.pieralisi@arm.com, jiaxun.yang@flygoat.com, chenhuacai@loongson.cn, loongson-kernel@lists.loongnix.cn X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Mar 2023 06:08:50 +0000, Jianmin Lv wrote: > > In pch_pic_parse_madt(), a NULL parent pointer will be > returned from acpi_get_vec_parent() for second pch-pic domain > related to second bridge while calling eiointc_acpi_init() at > first time, where the parent of it has not been initialized > yet, and will be initialized during second time calling > eiointc_acpi_init(). So, it's reasonable to return zero so > that failure of acpi_table_parse_madt() will be avoided, or else > acpi_cascade_irqdomain_init() will return and initialization of > followed pch_msi domain will be skipped. > > Although it does not matter when pch_msi_parse_madt() returns > -EINVAL if no invalid parent is found, it's also reasonable to > return zero for that. > > Change-Id: I4d278534999ec3e5c8db6d40155ba2665d9de86f > Signed-off-by: Jianmin Lv > --- > drivers/irqchip/irq-loongson-eiointc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c > index d15fd38c1756..62a632d73991 100644 > --- a/drivers/irqchip/irq-loongson-eiointc.c > +++ b/drivers/irqchip/irq-loongson-eiointc.c > @@ -343,7 +343,7 @@ static int __init pch_pic_parse_madt(union acpi_subtable_headers *header, > if (parent) > return pch_pic_acpi_init(parent, pchpic_entry); > > - return -EINVAL; > + return 0; Why can't you detect this particular case instead of blindly suppressing the error? M. -- Without deviation from the norm, progress is not possible.