Re: [PATCH rcu 01/27] arch/x86: Remove "select SRCU"

Paul E. McKenney
2023-01-09T19:22:37Z

On Mon, Jan 09, 2023 at 05:43:23PM +0000, Sean Christopherson wrote:
> On Wed, Jan 04, 2023, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: Sean Christopherson <seanjc@google.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: <x86@kernel.org>
> > Cc: <kvm@vger.kernel.org>
> > ---
>
> ...
>
> > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > index fbeaa9ddef598..9306d99585188 100644
> > --- a/arch/x86/kvm/Kconfig
> > +++ b/arch/x86/kvm/Kconfig
> > @@ -46,7 +46,6 @@ config KVM
> > select KVM_XFER_TO_GUEST_WORK
> > select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> > select KVM_VFIO
> > - select SRCU
>
> Would it be too much trouble to bundle all of the KVM changes into a single patch?
> The SRCU requirement is a generic KVM requirement that's handled in the arch Kconfigs
> purely because of KVM's somewhat roundabout Kconfig setup.

No problem, and will do on my next rebase. I might end up with a long
list of Cc's, but so it goes. I will of course send the result as a
reply to this message.

Thanx, Paul

> > select INTERVAL_TREE
> > select HAVE_KVM_PM_NOTIFIER if PM
> > help
> > --
> > 2.31.1.189.g2e36527f23
> >