public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Jun ASAKA <JunASAKA@zzy040330.moe>,
	"Jes.Sorensen\@gmail.com" <Jes.Sorensen@gmail.com>,
	"davem\@davemloft.net" <davem@davemloft.net>,
	"edumazet\@google.com" <edumazet@google.com>,
	"kuba\@kernel.org" <kuba@kernel.org>,
	"pabeni\@redhat.com" <pabeni@redhat.com>,
	"linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>,
	"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] wifi: rtl8xxxu: fixing IQK failures for rtl8192eu
Date: Wed, 07 Dec 2022 14:31:28 +0200	[thread overview]
Message-ID: <87h6y7mm3j.fsf@kernel.org> (raw)
In-Reply-To: <159ac3a296164b05b319bfb254a7901b@realtek.com> (Ping-Ke Shih's message of "Wed, 7 Dec 2022 03:55:16 +0000")

Ping-Ke Shih <pkshih@realtek.com> writes:

>> >> Fixing "Path A RX IQK failed" and "Path B RX IQK failed"
>> >> issues for rtl8192eu chips by replacing the arguments with
>> >> the ones in the updated official driver as shown below.
>> >> 1. https://github.com/Mange/rtl8192eu-linux-driver
>> >> 2. vendor driver version: 5.6.4
>> >>
>> >> Tested-by: Jun ASAKA <JunASAKA@zzy040330.moe>
>> >> Signed-off-by: Jun ASAKA <JunASAKA@zzy040330.moe>

The assumption is that the patch submitter tests the patches, so a
separate Tested-by tag is not needed. I'll remove it.

>> >> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
>> >> ---
>> >> v5:
>> >>   - no modification.
>> > Then, why do you need v5?
>> Well,  I just want to add the "Reviewed-By" line to the commit message.
>> Sorry for the noise if there is no need to do that.
>
> No need to add "Reviewed-By". Kalle will add it when this patch gets merged.

Yeah. And to be precise patchwork actually does that automatically, a
very nice feature :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  parent reply	other threads:[~2022-12-07 12:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07  3:39 [PATCH v5] wifi: rtl8xxxu: fixing IQK failures for rtl8192eu Jun ASAKA
2022-12-07  3:43 ` Ping-Ke Shih
2022-12-07  3:50   ` Jun ASAKA
2022-12-07  3:55     ` Ping-Ke Shih
2022-12-07  4:01       ` Jun ASAKA
2022-12-07 12:31       ` Kalle Valo [this message]
2022-12-08 14:53 ` [v5] " Kalle Valo
2022-12-09  3:46   ` Jun ASAKA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6y7mm3j.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=Jes.Sorensen@gmail.com \
    --cc=JunASAKA@zzy040330.moe \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox