From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 59650C433EF
	for <linux-kernel@archiver.kernel.org>; Tue,  7 Jun 2022 09:09:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S239043AbiFGJJu (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 7 Jun 2022 05:09:50 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55098 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S238762AbiFGJJt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Jun 2022 05:09:49 -0400
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20198369C3
        for <linux-kernel@vger.kernel.org>; Tue,  7 Jun 2022 02:09:47 -0700 (PDT)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
        (No client certificate requested)
        by smtp-out1.suse.de (Postfix) with ESMTPS id A650821B2E;
        Tue,  7 Jun 2022 09:09:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1654592986; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=TfFcXf1hj12Nx1LfqrKz8MfMIvOtfXkX8OrqFYBpYmM=;
        b=mho0hgkiRJA0lfEjYewH+qVjOj3P74ECQILEf8ARbFxHVTUrrrT2EnXRaBohsklSqsvrbV
        A72g3Nfg1EkLoj2AvRnjd0sMVz3zoV17k7DmN3b89J19hOMohfeLFcl0f4gJsocty6uiO4
        ljLX3j8jiGPm2EeCiR7ZetTrA2mUmEo=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1654592986;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=TfFcXf1hj12Nx1LfqrKz8MfMIvOtfXkX8OrqFYBpYmM=;
        b=JMa2rdqtXYBKH+Jzio6Snb4tg13j5QI2GRkJzUZJkXNa40fKaOreE3kaqf+WnHpvQTamOE
        OXz7Y4cZi8Cw5mCQ==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
        (No client certificate requested)
        by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6A2B213638;
        Tue,  7 Jun 2022 09:09:46 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
        by imap2.suse-dmz.suse.de with ESMTPSA
        id TeESGdoVn2K2KgAAMHmgww
        (envelope-from <tiwai@suse.de>); Tue, 07 Jun 2022 09:09:46 +0000
Date:   Tue, 07 Jun 2022 11:09:45 +0200
Message-ID: <87h74won52.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     huangwenhui <huangwenhuia@uniontech.com>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        kailang@realtek.com, tanureal@opensource.cirrus.com,
        jeremy.szu@canonical.com, linux-kernel@vger.kernel.org,
        wse@tuxedocomputers.com, hui.wang@canonical.com, sami@loone.fi,
        cam@neo-zeon.de
Subject: Re: [PATCH] ALSA: hda/realtek - Add HW8326 support
In-Reply-To: <20220607084109.29120-1-huangwenhuia@uniontech.com>
References: <20220607084109.29120-1-huangwenhuia@uniontech.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 07 Jun 2022 10:41:09 +0200,
huangwenhui wrote:
> 
> Added the support of new Huawei codec HW8326.
> 

It'd be appreciated if you describe about the hardware a bit more.
It looks like a compatible chip with some other Realtek codecs
(ALC256?).

> @@ -11479,6 +11492,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
>  	HDA_CODEC_ENTRY(0x10ec0236, "ALC236", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0245, "ALC245", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0255, "ALC255", patch_alc269),
> +	HDA_CODEC_ENTRY(0x19e58326, "HW8326", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0256, "ALC256", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0257, "ALC257", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0260, "ALC260", patch_alc260),

This table is sorted in the codec ID order.  Please put at the
appropriate place (at the last), instead.


thanks,

Takashi