Re: [PATCH v3 1/3] arm64: dts: marvell: espressobin-ultra: fix SPI-NOR config

Robert Marko
2022-03-24T12:20:17Z

On Tue, Sep 28, 2021 at 7:09 PM Robert Marko <robert.marko@sartura.hr> wrote:
>
> SPI config for the SPI-NOR is incorrect and completely breaking
> reading/writing to the onboard SPI-NOR.
>
> SPI-NOR is connected in the single(x1) IO mode and not in the quad
> (x4) mode.
> Also, there is no need to override the max frequency from the DTSI
> as the mx25u3235f that is used supports 104Mhz.
>
> Fixes: 3404fe15a60f ("arm64: dts: marvell: add DT for ESPRESSObin-Ultra")
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> Changes in v3:
> * Add Fixes tag
> ---
> arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index c5eb3604dd5b..610ff6f385c7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -71,10 +71,6 @@ &sdhci1 {
>
> &spi0 {
> flash@0 {
> - spi-max-frequency = <108000000>;
> - spi-rx-bus-width = <4>;
> - spi-tx-bus-width = <4>;
> -
> partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> --
> 2.31.1
>

Hi,

It would be great to get a review of the series or at least of this patch,
otherwise, the SPI-NOR is unusable.

Regards,
Robert

--
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr