From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A217C4332F for ; Mon, 28 Mar 2022 13:37:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243266AbiC1Nio (ORCPT ); Mon, 28 Mar 2022 09:38:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232753AbiC1Nim (ORCPT ); Mon, 28 Mar 2022 09:38:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6D3E000; Mon, 28 Mar 2022 06:37:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C89C26100C; Mon, 28 Mar 2022 13:37:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A87FC004DD; Mon, 28 Mar 2022 13:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648474621; bh=f68Fz/lCm29N+mGAJHutL3hGwitUR9q9IHkROMsM4m4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Mx2+d4qaTjnIHBGFff06f3YA0dDdXscwRqaAw73SxyKA5aCxEOwjGQfCLmSrYqK4Z 4b31e+YYpIioI+yVt94wwCQ6IpM/f8yjQbQRMp5vJEgrEMuC373ChHOFC/DbLC47Vi 90rJvmeyHBcsPB9oWuwETHY+6W0cw4DlXpj7mKz3sJsHWccf9vnYbtj9BdIhH46oaq XDEZy2oMP4dBl5DoB6Z4aC/r8ou42YM0tftp5sDPNdbSPd5TloAikaXmFwfT0IFE7m MkHCCwJ6bUfoRrAgGtiTiyU/vdzJLic3cnLbG0Qro929wLOv06h5U9ZexzNLthx7tO 58OwBd4ZVgQRA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nYpYI-00HQkS-N1; Mon, 28 Mar 2022 14:36:58 +0100 Date: Mon, 28 Mar 2022 14:36:54 +0100 Message-ID: <87h77ifbbd.wl-maz@kernel.org> From: Marc Zyngier To: yuzhe Cc: james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, liqiong@nfschina.com, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings In-Reply-To: <20220328103836.2829-1-yuzhe@nfschina.com> References: <20220328103836.2829-1-yuzhe@nfschina.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yuzhe@nfschina.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, liqiong@nfschina.com, kernel-janitors@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Mar 2022 11:38:36 +0100, yuzhe wrote: > > remove unnecessary castings, from "void *" to "struct kvm *" > > Signed-off-by: yuzhe > --- > arch/arm64/kvm/vgic/vgic-debug.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c > index f38c40a76251..927e5c1f650d 100644 > --- a/arch/arm64/kvm/vgic/vgic-debug.c > +++ b/arch/arm64/kvm/vgic/vgic-debug.c > @@ -82,7 +82,7 @@ static bool end_of_vgic(struct vgic_state_iter *iter) > > static void *vgic_debug_start(struct seq_file *s, loff_t *pos) > { > - struct kvm *kvm = (struct kvm *)s->private; > + struct kvm *kvm = s->private; > struct vgic_state_iter *iter; > > mutex_lock(&kvm->lock); > @@ -110,7 +110,7 @@ static void *vgic_debug_start(struct seq_file *s, loff_t *pos) > > static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos) > { > - struct kvm *kvm = (struct kvm *)s->private; > + struct kvm *kvm = s->private; > struct vgic_state_iter *iter = kvm->arch.vgic.iter; > > ++*pos; > @@ -122,7 +122,7 @@ static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos) > > static void vgic_debug_stop(struct seq_file *s, void *v) > { > - struct kvm *kvm = (struct kvm *)s->private; > + struct kvm *kvm = s->private; > struct vgic_state_iter *iter; > > /* > @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq, > > static int vgic_debug_show(struct seq_file *s, void *v) > { > - struct kvm *kvm = (struct kvm *)s->private; > + struct kvm *kvm = s->private; > struct vgic_state_iter *iter = (struct vgic_state_iter *)v; How about you fully get rid of the unnecessary casts then? M. -- Without deviation from the norm, progress is not possible.