From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F3EC12002 for ; Fri, 16 Jul 2021 17:37:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D06C61402 for ; Fri, 16 Jul 2021 17:37:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231303AbhGPRjy (ORCPT ); Fri, 16 Jul 2021 13:39:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230287AbhGPRjx (ORCPT ); Fri, 16 Jul 2021 13:39:53 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AD36C06175F for ; Fri, 16 Jul 2021 10:36:58 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 877D01F4409D From: Gabriel Krisman Bertazi To: Vijendar Mukunda Cc: , , , , Liam Girdwood , "Jaroslav Kysela" , Takashi Iwai , "Ravulapati Vishnu vardhan rao" , open list Subject: Re: [PATCH V2 12/12] ASoC: amd: enable vangogh acp5x driver build References: <20210716150809.21450-1-vijendar.mukunda@amd.com> <20210716150809.21450-13-vijendar.mukunda@amd.com> Date: Fri, 16 Jul 2021 13:36:51 -0400 In-Reply-To: <20210716150809.21450-13-vijendar.mukunda@amd.com> (Vijendar Mukunda's message of "Fri, 16 Jul 2021 20:38:09 +0530") Message-ID: <87h7guduto.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Vijendar Mukunda writes: > Vangogh ACP5x drivers can be built by selecting necessary > kernel config option. > The patch enables build support of the same. > > Signed-off-by: Vijendar Mukunda > --- > v1 -> v2: remove extra line in Make file > --- > sound/soc/amd/Kconfig | 9 +++++++++ > sound/soc/amd/Makefile | 1 + > sound/soc/amd/vangogh/Makefile | 11 +++++++++++ > 3 files changed, 21 insertions(+) > create mode 100644 sound/soc/amd/vangogh/Makefile > > diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig > index ba5a85bf7412..cc48d4e5b080 100644 > --- a/sound/soc/amd/Kconfig > +++ b/sound/soc/amd/Kconfig > @@ -52,3 +52,12 @@ config SND_SOC_AMD_RENOIR_MACH > depends on SND_SOC_AMD_RENOIR > help > This option enables machine driver for DMIC > + > +config SND_SOC_AMD_ACP5x > + tristate "AMD Audio Coprocessor-v5.x I2S support" > + depends on X86 && PCI > + help > + This option enables ACP v5.x support on AMD platform > + > + By enabling this flag build will trigger for ACP PCI driver, > + ACP DMA drvier, CPU DAI driver. > diff --git a/sound/soc/amd/Makefile b/sound/soc/amd/Makefile > index e6df2f72a2a1..07150d26f315 100644 > --- a/sound/soc/amd/Makefile > +++ b/sound/soc/amd/Makefile > @@ -10,3 +10,4 @@ obj-$(CONFIG_SND_SOC_AMD_CZ_RT5645_MACH) += snd-soc-acp-rt5645-mach.o > obj-$(CONFIG_SND_SOC_AMD_ACP3x) += raven/ > obj-$(CONFIG_SND_SOC_AMD_RV_RT5682_MACH) += snd-soc-acp-rt5682-mach.o > obj-$(CONFIG_SND_SOC_AMD_RENOIR) += renoir/ > +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += vangogh/ > diff --git a/sound/soc/amd/vangogh/Makefile b/sound/soc/amd/vangogh/Makefile > new file mode 100644 > index 000000000000..ae2cda804e2f > --- /dev/null > +++ b/sound/soc/amd/vangogh/Makefile > @@ -0,0 +1,11 @@ > +# SPDX-License-Identifier: GPL-2.0+ > +# Vangogh platform Support > +snd-pci-acp5x-objs := pci-acp5x.o > +snd-acp5x-i2s-objs := acp5x-i2s.o > +snd-acp5x-pcm-dma-objs := acp5x-pcm-dma.o > +snd-soc-acp5x-mach-objs := acp5x-nu8821-cs35l41.o > + > +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-pci-acp5x.o > +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-acp5x-i2s.o > +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-acp5x-pcm-dma.o > +obj-$(CONFIG_SND_SOC_AMD_VANGOGH_MACH) += snd-soc-acp5x-mach.o Looks like CONFIG_SND_SOC_AMD_VANGOGH_MACH is not selected by another symbol and also not configurable in kconfig. Is it missing a kconfig entry? -- Gabriel Krisman Bertazi